Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Thaw + 1.23 milestone_applier configuration #23128

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Code Thaw + 1.23 milestone_applier configuration #23128

merged 2 commits into from
Aug 4, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Aug 4, 2021

This pull request adds the following two commits:

  1. Lifts the 1.22 Code Freeze by removing the v1.22 milestone
    restriction fromk/k:master and k/k:release-1.22.

  2. updates the ilestone_applier plugin to stamp the
    following repos with the v1.23 milestone:

kubernetes/enhancements
kubernetes/kubernetes
kubernetes/org
kubernetes/release
kubernetes/sig-release
kubernetes/test-infra
kubernetes/k8s.io

/hold until the release finishes
/milestone v1.22
/sig release
/area release-eng
cc: @kubernetes/release-engineering @kubernetes/release-team

Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net

puerco added 2 commits August 4, 2021 13:42
@puerco
Post v1.22.0 Code Thaw
f0bfaf5 
This commit lifts the 1.22 Code Freeze by removing the milestone
restriction from k/k:master and  k/k:release-1.22.

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@puerco
Update milestone_applier plugin to v1.23
80579c8 
This commit updates the ilestone_applier plugin to stamp the
following repos wjth the v1.23 milestone:

```
kubernetes/enhancements
kubernetes/kubernetes
kubernetes/org
kubernetes/release
kubernetes/sig-release
kubernetes/test-infra
kubernetes/k8s.io
```

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 4, 2021
spiffxp
spiffxp approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2021
@dims
Copy link
Member

dims commented Aug 4, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, puerco, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member Author

puerco commented Aug 4, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit b4d0dfa into kubernetes:master Aug 4, 2021
@k8s-ci-robot
Copy link
Contributor

@puerco: Updated the following 2 configmaps:

  • config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml
  • plugins configmap in namespace default at cluster test-infra-trusted using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

This pull request adds the following two commits:

  1. Lifts the 1.22 Code Freeze by removing the v1.22 milestone
    restriction fromk/k:master and k/k:release-1.22.

  2. updates the ilestone_applier plugin to stamp the
    following repos with the v1.23 milestone:

kubernetes/enhancements
kubernetes/kubernetes
kubernetes/org
kubernetes/release
kubernetes/sig-release
kubernetes/test-infra
kubernetes/k8s.io

/hold until the release finishes
/milestone v1.22
/sig release
/area release-eng
cc: @kubernetes/release-engineering @kubernetes/release-team

Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@puerco @dims @k8s-ci-robot @spiffxp