prow.k8s.io: add skip reason to Spyglass JUnit lens

[Priyankasaggu11929]

What does this PR do:

At present, when an e2e test is skipped, the reason for the skip (if passed to the e2eskipper.Skipf function) is reflected in the artifacts/junit-*.xml files, but not on the Prow Spyglass JUnit lens:

For example, in case of the following job:

• JUnit file: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-csi-1-21-on-kubernetes-master/1491563973357604864/artifacts/junit_parallel.xml
• Spyglass lens: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-csi-1-21-on-kubernetes-master/1491563973357604864

This PR adds the skipped reason to the JUnit spyglass lens's template.html file (wherever passed).

The outcome is as follows (updated):

---

Addresses Issue:

Fixes #24209

[petr-muller]

Thank you! I wonder if it would be useful to include an explicit Reason: prefix? Up to you.

Suggested change

	<td class="mdl-data-table__cell--non-numeric test-name">{{$firstTest.ClassName}}: {{$firstTest.Name}}<br/>{{$firstTest.Skipped}}</td>
	<td class="mdl-data-table__cell--non-numeric test-name">{{$firstTest.ClassName}}: {{$firstTest.Name}}<br/>Reason: {{$firstTest.Skipped}}</td>

/hold

[Priyankasaggu11929]

@petr-muller, thank you for your feedback. I've revised the PR to include the suggestion for an explicit Reason: prefix.

Adding context to the new changes:

• There are cases (mainly) where skipped tests do not pass any skipped reason string to the e2eskipper.Skipf method. So I added an if/else conditional check in the go template to handle the scenarios of an empty skipped reason (which required the addition of a helper function SkippedReason() in thelens.go file)
• I created the new function because:
  • directly using {{ if eq $firstTest.Skipped "" }} in the go template didn't work, throwing incompatible string & pointer type comparisons. Here's a similar example.
  • Or in case of using{{if $firstTest.Skipped}}, it is never False (since it is always pointing to an empty skipped reason, therefore the conditional didn't move).

The updated result is as follows:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, petr-muller, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• prow/OWNERS [cjwagner,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Priyankasaggu11929]

@cjwagner @petr-muller, thanks so much for the review!

The PR above has a '/hold' on it, which is stopping it from merging. I need help removing that. Thank you! 🙂

[petr-muller]

/hold cancel

@Priyankasaggu11929 you can use commands like the one above too ;)

[Priyankasaggu11929]

/retest