-
Notifications
You must be signed in to change notification settings - Fork 2.7k
add kubernetes-verify-go-licenses-periodical job #26220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kubernetes-verify-go-licenses-periodical job #26220
Conversation
/hold Remove hold after PR kubernetes/kubernetes#109299 is merged |
@dims, This is WIP PR for the verify-licenses periodic job. I need information on the following bits:
|
/assign @MadhavJivrajani @nikhita |
115697f
to
7fc31a3
Compare
@Priyankasaggu11929 can we please revive this? looks like line 149 and column 54 probably?
|
Hello @dims, actually I was waiting on some information on the bits here #26220 (comment) When last I checked the failing test logs, it was complaining for adding testgrid dashboards meta. I will revise the PR tomorrow (my morning). Just need help in confirming the information bits in the above comment? Thank you! |
No, let's do the same as we did with
6 Hours is good. we don't really care which cluster this runs in, leave it empty
Add the minimum required to pass verification
Start with similar to
|
082c306
to
c6d8e54
Compare
/unhold |
@dims, updated the PR. PTAL. Thank you! 🙂 |
Let's give it a shot! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Priyankasaggu11929: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The PR adds a periodic job
ci-kubernetes-verify-go-licenses
, to partly address the asks from the Issue kubernetes/kubernetes#108942 (comment):Which issue(s) this PR fixes:
Part of the fix for kubernetes/kubernetes#108942