Skip to content

add kubernetes-verify-go-licenses-periodical job #26220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Priyankasaggu11929
Copy link
Member

What this PR does / why we need it:

The PR adds a periodic job ci-kubernetes-verify-go-licenses , to partly address the asks from the Issue kubernetes/kubernetes#108942 (comment):

We need to monitor all kubernetes repos for (At least start with k/k)

Which issue(s) this PR fixes:

Part of the fix for kubernetes/kubernetes#108942

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels May 6, 2022
@k8s-ci-robot k8s-ci-robot requested review from spiffxp and wojtek-t May 6, 2022 05:06
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 6, 2022
@Priyankasaggu11929
Copy link
Member Author

/hold

Remove hold after PR kubernetes/kubernetes#109299 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2022
@Priyankasaggu11929
Copy link
Member Author

Priyankasaggu11929 commented May 6, 2022

@dims, This is WIP PR for the verify-licenses periodic job.

I need information on the following bits:

  • Do we want to add the job as canary first?
  • What needs to be the job interval (6 hours) & what build cluster to be used - k8s-infra-prow-build?
  • Whether/not to add Testgrid dashboard/tabs/alert-emails information?
  • I'm not sure about what the Environment variables in the other similar jobs means? Need help identifying the required ones here.
  • What resource limits/requests to be set?

@dims
Copy link
Member

dims commented May 6, 2022

/assign @MadhavJivrajani @nikhita

@dims
Copy link
Member

dims commented Jun 2, 2022

@Priyankasaggu11929 can we please revive this? looks like make verify-yamllint fails

line 149 and column 54 probably?

config/jobs/kubernetes/sig-testing/verify.yaml
  149:54    error    trailing spaces  (trailing-spaces)

@Priyankasaggu11929
Copy link
Member Author

Hello @dims, actually I was waiting on some information on the bits here #26220 (comment)

When last I checked the failing test logs, it was complaining for adding testgrid dashboards meta. I will revise the PR tomorrow (my morning).

Just need help in confirming the information bits in the above comment? Thank you!

@dims
Copy link
Member

dims commented Jun 2, 2022

  • Do we want to add the job as canary first?

No, let's do the same as we did with check-dependency-stats-periodical

  • What needs to be the job interval (6 hours) & what build cluster to be used - k8s-infra-prow-build?

6 Hours is good. we don't really care which cluster this runs in, leave it empty

  • Whether/not to add Testgrid dashboard/tabs/alert-emails information?

Add the minimum required to pass verification

  • I'm not sure about what the Environment variables in the other similar jobs means? Need help identifying the required ones here.

Start with similar to check-dependency-stats-periodical, if things fail, we can try to fix it (don't worry about those env vars)

  • What resource limits/requests to be set?

check-dependency-stats-periodical doesn't set any, so we should leave it alone

@Priyankasaggu11929 Priyankasaggu11929 force-pushed the psaggu-periodic-verify-go-licenses branch from 082c306 to c6d8e54 Compare June 3, 2022 05:41
@Priyankasaggu11929 Priyankasaggu11929 changed the title WIP: add periodic ci-kubernetes-verify-go-licenses job add kubernetes-verify-go-licenses-periodical job Jun 3, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2022
@Priyankasaggu11929
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@Priyankasaggu11929
Copy link
Member Author

@dims, updated the PR. PTAL. Thank you! 🙂

@dims
Copy link
Member

dims commented Jun 3, 2022

Let's give it a shot!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit ae04c78 into kubernetes:master Jun 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

@Priyankasaggu11929: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml

In response to this:

What this PR does / why we need it:

The PR adds a periodic job ci-kubernetes-verify-go-licenses , to partly address the asks from the Issue kubernetes/kubernetes#108942 (comment):

We need to monitor all kubernetes repos for (At least start with k/k)

Which issue(s) this PR fixes:

Part of the fix for kubernetes/kubernetes#108942

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants