Skip to content

add warnings to existing Prow docs#26458

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
listx:add-modification-warnings-to-prow-docs
Jun 1, 2022
Merged

add warnings to existing Prow docs#26458
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
listx:add-modification-warnings-to-prow-docs

Conversation

@listx
Copy link
Contributor

@listx listx commented Jun 1, 2022

Part of kubernetes-sigs/prow#4.

This change just adds highly visible, almost obnoxious comments that are only visible to those who would like to make modifications to these files. The files now live in kubernetes-sigs/prow#10 under the "Legacy Snapshot" subdirectory.

The next phase of this migration likely involves "promoting" each file out of the "Legacy Snapshot" directory there to a less "Legacy ..."-sounding path, and once that's done, deleting the original file here so as to force users to use docs.prow.k8s.io as the source of truth.

/assign @cjwagner

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/prow Issues or PRs related to prow labels Jun 1, 2022
@k8s-ci-robot k8s-ci-robot requested review from chaodaiG and chases2 June 1, 2022 00:20
@k8s-ci-robot k8s-ci-robot added area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/clonerefs Issues or PRs related to prow's clonerefs component approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/config-bootstrapper Issues or PRs related to prow's config-bootstrapper utility area/prow/crier Issues or PRs related to prow's crier component area/prow/deck Issues or PRs related to prow's deck component area/prow/entrypoint Issues or PRs related to prow's entrypoint component area/prow/gcsupload Issues or PRs related to prow's gcsupload component area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/hook Issues or PRs related to prow's hook component area/prow/initupload Issues or PRs related to prow's initupload component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/peribolos Issues or PRs related to prow's peribolos component area/prow/phony Issues or PRs related to prow's phony component area/prow/plank Issues or PRs related to prow's plank component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component area/prow/sidecar Issues or PRs related to prow's sidecar component area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow/status-reconciler Issues or PRs related to reconciling status when jobs change area/prow/tide Issues or PRs related to prow's tide component area/prow/tot Issues or PRs related to prow's tot component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 1, 2022
@cjwagner
Copy link
Member

cjwagner commented Jun 1, 2022

I think this is a perfect use case for the blockade plugin. It allows us to block PRs from merging if they touch certain file paths. You can find a example config in the "details" here.

@listx
Copy link
Contributor Author

listx commented Jun 1, 2022

here

Indeed! Let me update this to use the plugin. I think I'll still leave the topmost comment in each file explaining why the file is "blocked", but otherwise remove the other "obnoxious" lines.

EDIT: It appears the blockade plugin can be configured to post a comment explaining the rationale behind the blockade, so discard my last sentence.

@listx listx force-pushed the add-modification-warnings-to-prow-docs branch from 9db853d to 3026b3b Compare June 1, 2022 04:42
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 1, 2022
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

- kubernetes/test-infra
blockregexps:
- ^prow/.+\.md$
explanation: "All Prow documentation (Markdown files) have moved to https://github.com/kubernetes-sigs/prow as part of https://github.com/kubernetes-sigs/prow/issues/4."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we'll want some exceptions. In particular we're definitely still going to want a README for Prow as a whole, even if it only really points to the documentation site. We might want other READMEs too? WDYT?

We can tweak this later so we don't need to determine this now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception for main Prow README sounds fine. I'm not sure which other ones need exceptions, so I'd rather leave that up to future PRs as they come up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added exception for prow/README.md.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 1, 2022
Add an exception for the toplevel Prow README.md.
@listx listx force-pushed the add-modification-warnings-to-prow-docs branch from 3026b3b to af9113d Compare June 1, 2022 20:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2022
@cjwagner
Copy link
Member

cjwagner commented Jun 1, 2022

/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, listx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c74b05 into kubernetes:master Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 1, 2022
@k8s-ci-robot
Copy link
Contributor

@listx: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml
Details

In response to this:

Part of kubernetes-sigs/prow#4.

This change just adds highly visible, almost obnoxious comments that are only visible to those who would like to make modifications to these files. The files now live in kubernetes-sigs/prow#10 under the "Legacy Snapshot" subdirectory.

The next phase of this migration likely involves "promoting" each file out of the "Legacy Snapshot" directory there to a less "Legacy ..."-sounding path, and once that's done, deleting the original file here so as to force users to use docs.prow.k8s.io as the source of truth.

/assign @cjwagner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/clonerefs Issues or PRs related to prow's clonerefs component area/prow/config-bootstrapper Issues or PRs related to prow's config-bootstrapper utility area/prow/crier Issues or PRs related to prow's crier component area/prow/deck Issues or PRs related to prow's deck component area/prow/entrypoint Issues or PRs related to prow's entrypoint component area/prow/gcsupload Issues or PRs related to prow's gcsupload component area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/hook Issues or PRs related to prow's hook component area/prow/initupload Issues or PRs related to prow's initupload component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/peribolos Issues or PRs related to prow's peribolos component area/prow/phony Issues or PRs related to prow's phony component area/prow/plank Issues or PRs related to prow's plank component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component area/prow/sidecar Issues or PRs related to prow's sidecar component area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow/status-reconciler Issues or PRs related to reconciling status when jobs change area/prow/tide Issues or PRs related to prow's tide component area/prow/tot Issues or PRs related to prow's tot component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments