add warnings to existing Prow docs#26458
Conversation
|
I think this is a perfect use case for the |
Indeed! Let me update this to use the plugin. I think I'll still leave the topmost comment in each file explaining why the file is "blocked", but otherwise remove the other "obnoxious" lines. EDIT: It appears the blockade plugin can be configured to post a comment explaining the rationale behind the blockade, so discard my last sentence. |
9db853d to
3026b3b
Compare
| - kubernetes/test-infra | ||
| blockregexps: | ||
| - ^prow/.+\.md$ | ||
| explanation: "All Prow documentation (Markdown files) have moved to https://github.com/kubernetes-sigs/prow as part of https://github.com/kubernetes-sigs/prow/issues/4." |
There was a problem hiding this comment.
I suspect we'll want some exceptions. In particular we're definitely still going to want a README for Prow as a whole, even if it only really points to the documentation site. We might want other READMEs too? WDYT?
We can tweak this later so we don't need to determine this now.
There was a problem hiding this comment.
Exception for main Prow README sounds fine. I'm not sure which other ones need exceptions, so I'd rather leave that up to future PRs as they come up.
There was a problem hiding this comment.
Added exception for prow/README.md.
Add an exception for the toplevel Prow README.md.
3026b3b to
af9113d
Compare
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, listx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@listx: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of kubernetes-sigs/prow#4.
This change just adds highly visible, almost obnoxious comments that are only visible to those who would like to make modifications to these files. The files now live in kubernetes-sigs/prow#10 under the "Legacy Snapshot" subdirectory.
The next phase of this migration likely involves "promoting" each file out of the "Legacy Snapshot" directory there to a less "Legacy ..."-sounding path, and once that's done, deleting the original file here so as to force users to use docs.prow.k8s.io as the source of truth.
/assign @cjwagner