New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit self-approve to k/community #5844

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
3 participants
@cblecker
Member

cblecker commented Dec 6, 2017

People are used to this, so might as well turn it on.

@BenTheElder

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 6, 2017

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Dec 6, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Dec 6, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Dec 6, 2017

Member

/hold cancel
Thanks @BenTheElder !

Member

cblecker commented Dec 6, 2017

/hold cancel
Thanks @BenTheElder !

@k8s-ci-robot k8s-ci-robot merged commit fdb836a into kubernetes:master Dec 6, 2017

7 checks passed

cla/linuxfoundation cblecker authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Dec 6, 2017

Contributor

@cblecker: I updated Prow plugins config for you!

In response to this:

People are used to this, so might as well turn it on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Dec 6, 2017

@cblecker: I updated Prow plugins config for you!

In response to this:

People are used to this, so might as well turn it on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the cblecker:patch-1 branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment