Rename github.com/kubernetes/test-infra/ciongke -> k8s.io/test-infra/prow.#835
Merged
Conversation
Contributor
|
Jenkins go test failed for commit ec6e5f7. Full PR test history. The magic incantation to run this job again is |
Contributor
|
Maybe update https://github.com/kubernetes/k8s.io/blob/master/k8s.io/configmap-www-golang.yaml to add k8s.io/test-infra first? |
Contributor
Author
|
Nobody is go-getting this right now afaik, so the order doesn't matter much, but I'll make the PR now. |
foxish
pushed a commit
to foxish/test-infra
that referenced
this pull request
Jan 21, 2017
…icks State why we are enforcing the release note process on a cherrypick
ostromart
pushed a commit
to ostromart/test-infra
that referenced
this pull request
Jul 26, 2019
This reverts commit ded4304.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think it's go-gettable yet, but still worth making the change to keep it consistent with our other go projects.
It most likely won't pass on Jenkins because the docker run command is baked into the job config and not pulled into a script like it should be. I'd like to merge anyways, it will pass once the change goes in.
This change is