New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply label_sync to all managed kubernetes orgs #9054

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@spiffxp
Member

spiffxp commented Aug 15, 2018

I'd like to turn on label_sync for all kubernetes github orgs that are
actively in use

The repos in kubernetes-csi already use automation that depends on these labels

Some repos in kubernetes-incubator do

I would like to move kubernetes-client to have the same level of automation that
kubernetes-sigs does

WDYT?

/hold
for comment and consensusx

/sig contributor-experience
/area github-management

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Aug 15, 2018

Member

/lgtm

Needs consensus. I'm okay with 72 hours. Please send to k-dev :)
Label all the things!! 🗒

Member

cblecker commented Aug 15, 2018

/lgtm

Needs consensus. I'm okay with 72 hours. Please send to k-dev :)
Label all the things!! 🗒

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp
Member

spiffxp commented Aug 15, 2018

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker
Member

cblecker commented Aug 20, 2018

@spiffxp 🕒

@fejta

fejta approved these changes Aug 20, 2018

/lgtm

cancel hold?

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 20, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 21, 2018

Member

/hold cancel

Member

spiffxp commented Aug 21, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 64c3fa0 into kubernetes:master Aug 21, 2018

12 checks passed

cla/linuxfoundation spiffxp authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Job succeeded.
Details
tide In merge pool.
Details

@spiffxp spiffxp deleted the spiffxp:label-sync-all-the-orgs branch Aug 21, 2018

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 22, 2018

Member

... right, merging this PR doesn't actually cause the cronjob to get updated, that's something I get to do manually

I'm going to run a job while I'm at it

Member

spiffxp commented Aug 22, 2018

... right, merging this PR doesn't actually cause the cronjob to get updated, that's something I get to do manually

I'm going to run a job while I'm at it

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 22, 2018

Member

Fun facts I had to manually work around:

  • kubernetes-incubator/metrics-server had two identical labels named "cncf-cla: yes", on the same issues. I manually removed one of the labels.
  • kubernetes/website had a manually added triage/pr-requested label with a label description that was exactly one character too long, and caused label_sync to die. I removed the trailing period from its description
Member

spiffxp commented Aug 22, 2018

Fun facts I had to manually work around:

  • kubernetes-incubator/metrics-server had two identical labels named "cncf-cla: yes", on the same issues. I manually removed one of the labels.
  • kubernetes/website had a manually added triage/pr-requested label with a label description that was exactly one character too long, and caused label_sync to die. I removed the trailing period from its description
@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 22, 2018

Member

local dry run logs

Running the job

spiffxp@spiffxp-macbookpro:label_sync (add-k-utils-automation)$ make label_sync-job
gcloud container clusters get-credentials "prow" --project="k8s-prow" --zone="us-central1-f"
Fetching cluster endpoint and auth data.
kubeconfig entry generated for prow.
kubectl apply -f cluster/label_sync_job.yaml
job "label-sync" created
Member

spiffxp commented Aug 22, 2018

local dry run logs

Running the job

spiffxp@spiffxp-macbookpro:label_sync (add-k-utils-automation)$ make label_sync-job
gcloud container clusters get-credentials "prow" --project="k8s-prow" --zone="us-central1-f"
Fetching cluster endpoint and auth data.
kubeconfig entry generated for prow.
kubectl apply -f cluster/label_sync_job.yaml
job "label-sync" created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment