New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow/welcome: re-enable welcome plugin #9689

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
5 participants
@cblecker
Member

cblecker commented Oct 3, 2018

This reverts commit 0e7b828 and re-enables the prow plugin.

This should not be merged until after e21872d is deployed.

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 3, 2018

Member

/hold
/assign @BenTheElder

Member

cblecker commented Oct 3, 2018

/hold
/assign @BenTheElder

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 5, 2018

Member

I was going to do this today, but we also have the LGTM changes, so I'm going to hold bumping prow while we deal with bumping go in k/k and circle back to this next week

Member

BenTheElder commented Oct 5, 2018

I was going to do this today, but we also have the LGTM changes, so I'm going to hold bumping prow while we deal with bumping go in k/k and circle back to this next week

@cjwagner

This comment has been minimized.

Show comment
Hide comment
@cjwagner

cjwagner Oct 5, 2018

Member

Choosing not to bump on a Friday afternoon? That doesn't sound like our SOP /s

Member

cjwagner commented Oct 5, 2018

Choosing not to bump on a Friday afternoon? That doesn't sound like our SOP /s

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 5, 2018

Member

Oh, we're bumping all right, just not prow :-) #9716

Member

BenTheElder commented Oct 5, 2018

Oh, we're bumping all right, just not prow :-) #9716

@fejta

This comment has been minimized.

Show comment
Hide comment
@fejta

fejta Oct 11, 2018

Contributor

Looks like we're still running 0928 version. Shall I bump?

Contributor

fejta commented Oct 11, 2018

Looks like we're still running 0928 version. Shall I bump?

@fejta

This comment has been minimized.

Show comment
Hide comment
@fejta

fejta Oct 12, 2018

Contributor

Bumped to 1012, merge at your leisure

Contributor

fejta commented Oct 12, 2018

Bumped to 1012, merge at your leisure

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 12, 2018

Member

/hold cancel

@BenTheElder ping for lgtm/approve :)

Member

cblecker commented Oct 12, 2018

/hold cancel

@BenTheElder ping for lgtm/approve :)

@BenTheElder

/lgtm
/approve
/hold cancel
/meow space

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 12, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 12, 2018

Contributor

@BenTheElder: cat image

In response to this:

/lgtm
/approve
/hold cancel
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Oct 12, 2018

@BenTheElder: cat image

In response to this:

/lgtm
/approve
/hold cancel
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 12, 2018

Contributor

LGTM label has been added.

Git tree hash: 9c8b67d346385140719294b56e4aaa7b0a2dc14c

Contributor

k8s-ci-robot commented Oct 12, 2018

LGTM label has been added.

Git tree hash: 9c8b67d346385140719294b56e4aaa7b0a2dc14c

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 12, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 12, 2018

Contributor

@cblecker: Updated the plugins configmap using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

This reverts commit 0e7b828 and re-enables the prow plugin.

This should not be merged until after e21872d is deployed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Oct 12, 2018

@cblecker: Updated the plugins configmap using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

This reverts commit 0e7b828 and re-enables the prow plugin.

This should not be merged until after e21872d is deployed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 30fa4c0 into kubernetes:master Oct 12, 2018

12 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:enable-welcome branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment