Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote gke jobs from release-blocking #9959

Merged

Conversation

@spiffxp
Copy link
Member

commented Oct 30, 2018

ref: kubernetes/sig-release#347

These jobs don't meet the release-blocking criteria laid out in https://github.com/kubernetes/sig-release/blob/master/release-blocking-jobs.md#release-blocking-criteria. Namely:

  • re: "provisions clusters via open-source software instead of a hosted service" - they use a hosted service

Removed gke jobs from the following sig-release dashboards:

  • sig-release-master-blocking
  • sig-release-master-upgrade (moved to -optional)
  • sig-release-1.12-blocking
  • sig-release-1.11-blocking
  • sig-release-1.10-blocking
  • sig-release-1.9-blocking

Left gke jobs on the following sig-release dashboards:

  • sig-release-master-kubectl-skew
  • sig-release-master-upgrade-optional
  • sig-release-1.12-all
  • sig-release-1.11-all
  • sig-release-1.10-all
  • sig-release-1.9-all

/sig release
/sig gcp
/kind cleanup

/hold
for comment

/cc @AishSundar @jberkus
Current release team lead and CI signal

/cc @MaciekPytel @foxish @feiskyer @tpepper
Patch release managers

/cc @jagosan @adamworrall
GKE, sig-gcp

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

@spiffxp: GitHub didn't allow me to request PR reviews from the following users: AdamWorrall.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Removed gke jobs from the following sig-release dashboards:

  • sig-release-master-blocking
  • sig-release-master-upgrade
  • sig-release-1.12-blocking
  • sig-release-1.11-blocking
  • sig-release-1.10-blocking
  • sig-release-1.9-blocking

Left gke jobs on the following sig-release dashboards:

  • sig-release-master-kubectl-skew
  • sig-release-master-upgrade-optional
  • sig-release-1.12-all
  • sig-release-1.11-all
  • sig-release-1.10-all
  • sig-release-1.9-all

/sig release
/sig gcp
/kind cleanup

ref: kubernetes/sig-release#347

/hold
for comment

/cc @AishSundar @jberkus
Current release team lead and CI signal

/cc @MaciekPytel @foxish @feiskyer @tpepper
Patch release managers

/cc @jagosan @adamworrall
GKE, sig-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

@k8s-ci-robot k8s-ci-robot requested a review from abgworrall Oct 30, 2018

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

Bazel is failing because the following jobs that I removed from the sig-release-master-upgrade board aren't referenced in any other testgrid dashboard:

  • ci-kubernetes-e2e-gke-gci-master-gci-new-downgrade-cluster
  • ci-kubernetes-e2e-gke-gci-new-gci-master-upgrade-cluster-new
  • ci-kubernetes-e2e-gke-gci-new-gci-master-upgrade-master
  • ci-kubernetes-e2e-gke-gci-new-gci-master-upgrade-cluster
  • ci-kubernetes-e2e-gke-gci-master-gci-new-downgrade-cluster-parallel
  • ci-kubernetes-e2e-gke-gci-new-gci-master-upgrade-cluster-new-parallel
  • ci-kubernetes-e2e-gke-gci-new-gci-master-upgrade-cluster-parallel

The quick fix is probably to move these to sig-release-master-upgrade-optional.

Longer term however I would like to consolidate or get rid of the sig-release-master-upgrade-optional and sig-release-master-kubectl-skew dashboards into a blocking/informing/all pattern.

So another option is google-gke-staging, which is already host to 1-10-1-11 and 1-11-1-12 jobs

@AishSundar

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

@spiffxp I thought we were going to move these non-blocking gke jobs to a release informing dashboard. May be creating that dashboard as part of this PR will help (i) not loose signal on these jobs and (ii) mitigate the bazel failure.

Demote gke jobs from release-blocking
Removed gke jobs from the following sig-release dashboards:

- sig-release-master-blocking
- sig-release-master-upgrade (moved to -optional)
- sig-release-1.12-blocking
- sig-release-1.11-blocking
- sig-release-1.10-blocking
- sig-release-1.9-blocking

Left gke jobs on the following sig-release dashboards:

- sig-release-master-kubectl-skew
- sig-release-master-upgrade-optional
- sig-release-1.12-all
- sig-release-1.11-all
- sig-release-1.10-all
- sig-release-1.9-all

@spiffxp spiffxp force-pushed the spiffxp:demote-gke-from-release-blocking branch from 93c2e0d to 4f5450c Oct 30, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Oct 30, 2018

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

I opted to move them to -upgrade-optional for now, will do -informing separately

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

do we still want them to run in OSS prow?

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

For now yes, but we just don't want the release team to spend a lot of time babysitting them

@AishSundar

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Moving to upgrade-optional sounds good since it has just 1 gke upgrade job now. Please remove hold once @jberkus gives the green signal as well. Thanks @spiffxp

/lgtm
/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

LGTM label has been added.

Git tree hash: fd2f15bc092d4cac492b5216226b06a3ef498e11

@jberkus

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

/lgtm

I'll have some input on which of the tests should be in informing vs all once this goes in.

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

I sent a heads up to k-dev@ https://groups.google.com/forum/#!topic/kubernetes-dev/8Po230FeEIs

Will remove /hold at 9am PT tomorrow

@jberkus

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Can you list which blocking criteria these tests are failing, for the record?

@jagosan

This comment has been minimized.

Copy link

commented Nov 1, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AishSundar, jagosan, jberkus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit d405b70 into kubernetes:master Nov 2, 2018

12 checks passed

cla/linuxfoundation spiffxp authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped
tide In merge pool.
Details

@spiffxp spiffxp deleted the spiffxp:demote-gke-from-release-blocking branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.