New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branchprotector and label_sync crons to hourly #9994

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@cblecker
Member

cblecker commented Nov 1, 2018

No description provided.

@cblecker

This comment has been minimized.

Member

cblecker commented Nov 1, 2018

/assign @fejta @cjwagner
I'd reeeeeeally like this.. wondering if there is concerns around token usage.

@cjwagner

This comment has been minimized.

Member

cjwagner commented Nov 1, 2018

Do we have an estimate for the peak API token usage for these jobs?

@cblecker

This comment has been minimized.

Member

cblecker commented Nov 1, 2018

I don't have that data, no.

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 1, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 1, 2018

LGTM label has been added.

Git tree hash: 6b1d60f73ac4438cabdddd32570db4b1456b7786

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta

This comment has been minimized.

Contributor

fejta commented Nov 1, 2018

LGTM

@k8s-ci-robot k8s-ci-robot merged commit 45e5ecd into kubernetes:master Nov 1, 2018

12 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:hourly-cron branch Nov 1, 2018

@cblecker

This comment has been minimized.

Member

cblecker commented Nov 1, 2018

@cjwagner @fejta do these need to be re-deployed?

@cjwagner

This comment has been minimized.

Member

cjwagner commented Nov 1, 2018

Yes, they do. Before:

NAME              SCHEDULE      SUSPEND   ACTIVE    LAST SCHEDULE   AGE
branchprotector   54 11 * * *   False     0         11h             276d
label-sync        17 23 * * *   False     0         18m             321d

After:

NAME              SCHEDULE     SUSPEND   ACTIVE    LAST SCHEDULE   AGE
branchprotector   54 * * * *   False     0         11h             276d
label-sync        17 * * * *   False     0         19m             321d
@cblecker

This comment has been minimized.

Member

cblecker commented Nov 1, 2018

Thanks muchly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment