-
Notifications
You must be signed in to change notification settings - Fork 208
ebtables: update the version check regex expression and added unit test #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Abhishek Agarwal <abhishek.agarwal@mayadata.io>
|
Welcome @Ab-hishek! |
|
/assign @thockin |
thockin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ab-hishek, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
/retest |
1 similar comment
|
/retest |
|
|
I don't know why the CLA bot barfed. @Ab-hishek can you please recheck it? |
|
Replaced by #272 |
Signed-off-by: Abhishek Agarwal abhishek.agarwal@mayadata.io
What type of PR is this?
/kind bug
What this PR does / why we need it:
Refactors the function used for getting the
ebtablesversion in the form"X.X.X" by adding a new function inside it namedparseVersion(string) (string, error)and also updates the regex expression to accommodate both version formats i.e with/withoutv. It also add unit for the above added function with a few interesting inputs.Which issue(s) this PR fixes:
Fixes #236
Special notes for your reviewer:
Release note: