From e31d646d7c8768edf4e101a833c8bbdffdebc5b5 Mon Sep 17 00:00:00 2001 From: Yassine Ilmi Date: Mon, 22 Aug 2022 19:21:57 +0200 Subject: [PATCH 1/2] Removing created-by label deprecated since 1.9 --- .../concepts/overview/working-with-objects/common-labels.md | 2 -- .../en/docs/reference/labels-annotations-taints/_index.md | 6 +++++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/content/en/docs/concepts/overview/working-with-objects/common-labels.md b/content/en/docs/concepts/overview/working-with-objects/common-labels.md index 210d33dcd4a32..97d8c95018b11 100644 --- a/content/en/docs/concepts/overview/working-with-objects/common-labels.md +++ b/content/en/docs/concepts/overview/working-with-objects/common-labels.md @@ -40,7 +40,6 @@ on every resource object. | `app.kubernetes.io/component` | The component within the architecture | `database` | string | | `app.kubernetes.io/part-of` | The name of a higher level application this one is part of | `wordpress` | string | | `app.kubernetes.io/managed-by` | The tool being used to manage the operation of an application | `helm` | string | -| `app.kubernetes.io/created-by` | The controller/user who created this resource | `controller-manager` | string | To illustrate these labels in action, consider the following {{< glossary_tooltip text="StatefulSet" term_id="statefulset" >}} object: @@ -56,7 +55,6 @@ metadata: app.kubernetes.io/component: database app.kubernetes.io/part-of: wordpress app.kubernetes.io/managed-by: helm - app.kubernetes.io/created-by: controller-manager ``` ## Applications And Instances Of Applications diff --git a/content/en/docs/reference/labels-annotations-taints/_index.md b/content/en/docs/reference/labels-annotations-taints/_index.md index d132642e2c51e..f298d0502c80f 100644 --- a/content/en/docs/reference/labels-annotations-taints/_index.md +++ b/content/en/docs/reference/labels-annotations-taints/_index.md @@ -25,7 +25,7 @@ The component within the architecture. One of the [recommended labels](/docs/concepts/overview/working-with-objects/common-labels/#labels). -### app.kubernetes.io/created-by +### app.kubernetes.io/created-by (deprecated) Example: `app.kubernetes.io/created-by: "controller-manager"` @@ -35,6 +35,10 @@ The controller/user who created this resource. One of the [recommended labels](/docs/concepts/overview/working-with-objects/common-labels/#labels). +{{< note >}} +Starting from v1.9, this annotation is deprecated. +{{< /note >}} + ### app.kubernetes.io/instance Example: `app.kubernetes.io/instance: "mysql-abcxzy"` From bf29b18145d2833cbb7ee5e3876d2402edb0daed Mon Sep 17 00:00:00 2001 From: Yassine Ilmi <9211413+yilmi@users.noreply.github.com> Date: Fri, 2 Sep 2022 14:58:26 +0200 Subject: [PATCH 2/2] Apply suggestion from sftim review Co-authored-by: Tim Bannister --- content/en/docs/reference/labels-annotations-taints/_index.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/content/en/docs/reference/labels-annotations-taints/_index.md b/content/en/docs/reference/labels-annotations-taints/_index.md index f298d0502c80f..09b3def7dd2bd 100644 --- a/content/en/docs/reference/labels-annotations-taints/_index.md +++ b/content/en/docs/reference/labels-annotations-taints/_index.md @@ -33,10 +33,8 @@ Used on: All Objects The controller/user who created this resource. -One of the [recommended labels](/docs/concepts/overview/working-with-objects/common-labels/#labels). - {{< note >}} -Starting from v1.9, this annotation is deprecated. +Starting from v1.9, this label is deprecated. {{< /note >}} ### app.kubernetes.io/instance