Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/ #11587

Closed
1 of 2 tasks
bgauduch opened this issue Dec 6, 2018 · 1 comment
Closed
1 of 2 tasks

Comments

@bgauduch
Copy link
Contributor

bgauduch commented Dec 6, 2018

This is a...

  • Feature Request
  • Bug Report

Problem:
In the chapter define-readiness-probes, the given example is misleading : people could understand that the readiness is only used when a container start and not for the rest of its life cycle (see issue 11018 for instance, happened to me as well).

Proposed Solution:
It would be nice to improve the explanation by stating more clearly that the readiness probe is effectively used during all the container life cycle.

For instance, something like: "Readiness probe are run on the container during all its life cycle to determine if the parent pod is ready to receive traffic or not."
Before : "A pod with containers reporting that they are not ready does not receive traffic through Kubernetes Services"

Maybe add some more exemple, like an app in a container depending on an external service (DB, Storage, ...) to illustrate the need of the readiness probe in a different scenario than startup.
For example, if the DB goes wild (network temporary issue/latency for instance), the readiness probe could detect that and allow the service to prevent traffic from hitting the related pod until things go back to normal.

Page to Update:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#define-readiness-probes

bgauduch added a commit to bgauduch/website that referenced this issue Dec 7, 2018
@bgauduch
Copy link
Contributor Author

bgauduch commented Dec 7, 2018

Created PR regarding this issue : PR 11613

k8s-ci-robot pushed a commit that referenced this issue Jan 3, 2019
* Update proposal for configure-liveness-readiness-probes.md

Proposal regarding [issue 11587](#11587)

* ✏️ corrected typo

* ✏️ corrected sentence

* Update configure-liveness-readiness-probes.md
immutableT pushed a commit to immutableT/website that referenced this issue Jan 9, 2019
…s#11613)

* Update proposal for configure-liveness-readiness-probes.md

Proposal regarding [issue 11587](kubernetes#11587)

* ✏️ corrected typo

* ✏️ corrected sentence

* Update configure-liveness-readiness-probes.md
immutableT pushed a commit to immutableT/website that referenced this issue Jan 9, 2019
…s#11613)

* Update proposal for configure-liveness-readiness-probes.md

Proposal regarding [issue 11587](kubernetes#11587)

* ✏️ corrected typo

* ✏️ corrected sentence

* Update configure-liveness-readiness-probes.md
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this issue Jan 29, 2019
…s#11613)

* Update proposal for configure-liveness-readiness-probes.md

Proposal regarding [issue 11587](kubernetes#11587)

* ✏️ corrected typo

* ✏️ corrected sentence

* Update configure-liveness-readiness-probes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant