Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description about local http proxy setting's effect on liveness probe #11567

Merged
merged 2 commits into from Dec 17, 2018
Merged

Add description about local http proxy setting's effect on liveness probe #11567

merged 2 commits into from Dec 17, 2018

Conversation

WanLinghao
Copy link
Contributor

Add description about local http proxy setting's effect on liveness probe
ref:kubernetes/kubernetes#68663

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4590b6c

https://deploy-preview-11567--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 6, 2018 •
edited

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2d9ef5d

https://deploy-preview-11567--kubernetes-io-master-staging.netlify.com

Rajakavitha1
Rajakavitha1 reviewed Dec 6, 2018
View reviewed changes
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @WanLinghao Just a few minor changes.
In releases prior to v1.13 and in v1.13, if http_proxy or HTTP_PROXY environment variables is set in the node on which a pod is running, the http liveness probe uses that proxy. In the releases after v1.13, local http proxy envirnment variables do not effect the http liveness probe.

@WanLinghao
Copy link
Contributor Author

@Rajakavitha1 Done PTAL

@tengqm
Copy link
Contributor

tengqm commented Dec 17, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7269c41 into kubernetes:master Dec 17, 2018
kychool pushed a commit to kychool/website that referenced this pull request Dec 26, 2018
@WanLinghao @kychool
Add description about local http proxy setting's effect on liveness p…
64619f8 
…robe (kubernetes#11567)

* Add description about local http proxy setting's effect on liveness probe

* Update configure-liveness-readiness-probes.md
kychool pushed a commit to kychool/website that referenced this pull request Dec 26, 2018
@WanLinghao @kychool
Add description about local http proxy setting's effect on liveness p…
1a88e32 
…robe (kubernetes#11567)

* Add description about local http proxy setting's effect on liveness probe

* Update configure-liveness-readiness-probes.md
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
@WanLinghao
Add description about local http proxy setting's effect on liveness p…
e157b45 
…robe (kubernetes#11567)

* Add description about local http proxy setting's effect on liveness probe

* Update configure-liveness-readiness-probes.md
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
@WanLinghao
Add description about local http proxy setting's effect on liveness p…
3c90be4 
…robe (kubernetes#11567)

* Add description about local http proxy setting's effect on liveness probe

* Update configure-liveness-readiness-probes.md
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
@WanLinghao @bsalamat
Add description about local http proxy setting's effect on liveness p…
a2f7063 
…robe (kubernetes#11567)

* Add description about local http proxy setting's effect on liveness probe

* Update configure-liveness-readiness-probes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Rajakavitha1 left review comments

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@WanLinghao @k8sio-netlify-preview-bot @tengqm @k8s-ci-robot @Rajakavitha1