Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-trans: Added the blog post about NCW Shanghai #11896

Merged
merged 1 commit into from Jan 2, 2019

Conversation

@idealhack
Copy link
Member

idealhack commented Dec 26, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Dec 26, 2018

@idealhack: GitHub didn't allow me to request PR reviews from the following users: puja108.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @puja108 @xiangpengzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idealhack

This comment has been minimized.

Copy link
Member Author

idealhack commented Dec 26, 2018

@k8s-ci-robot k8s-ci-robot requested review from chenrui333 and tengqm Dec 26, 2018

@k8sio-netlify-preview-bot

This comment has been minimized.

Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 26, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 56c5967

https://deploy-preview-11896--kubernetes-io-master-staging.netlify.com

@idealhack idealhack force-pushed the idealhack:zh-add-blog-ncw-shanghai branch from 1b01dbb to 83a4c39 Dec 26, 2018

@idealhack idealhack changed the title zh: Translated the blog post about NCW Shanghai zh-trans: Added the blog post about NCW Shanghai Dec 26, 2018

@idealhack

This comment has been minimized.

Copy link
Member Author

idealhack commented Dec 27, 2018

@puja108 Feel free to request membership at k/org, I can be one of the sponsors 😇

@chenrui333

This comment has been minimized.

Copy link
Member

chenrui333 commented Dec 29, 2018

留了一些建议,基本 lgtm。

@idealhack idealhack force-pushed the idealhack:zh-add-blog-ncw-shanghai branch from 83a4c39 to 0beda83 Dec 29, 2018

@idealhack

This comment has been minimized.

Copy link
Member Author

idealhack commented Dec 29, 2018

Comments addressed, more feedbacks welcome.

@idealhack

This comment has been minimized.

Copy link
Member Author

idealhack commented Dec 29, 2018

/assign @markthink @tengqm
for approval

@chenrui333

This comment has been minimized.

Copy link
Member

chenrui333 commented Dec 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 29, 2018

@idealhack idealhack force-pushed the idealhack:zh-add-blog-ncw-shanghai branch from 0beda83 to 8e685c4 Dec 30, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 30, 2018

@xiangpengzhao
Copy link
Member

xiangpengzhao left a comment

仅有一点小的修改建议(也可以不用改)。整体翻译非常赞!👍

@idealhack idealhack force-pushed the idealhack:zh-add-blog-ncw-shanghai branch from 8e685c4 to 56c5967 Dec 31, 2018

@idealhack

This comment has been minimized.

Copy link
Member Author

idealhack commented Dec 31, 2018

Ready for a final review, can we merge this in 2018? 😄

@markthink
Copy link
Member

markthink left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

k8s-ci-robot commented Jan 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a467484 into kubernetes:master Jan 2, 2019

4 checks passed

cla/linuxfoundation idealhack authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
tide In merge pool.
Details

immutableT added a commit to immutableT/website that referenced this pull request Jan 9, 2019

immutableT added a commit to immutableT/website that referenced this pull request Jan 9, 2019

bsalamat added a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.