Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init French translation #12548

Merged
merged 1 commit into from Feb 13, 2019

Conversation

@remyleone
Copy link
Contributor

commented Feb 8, 2019

No description provided.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@netlify

This comment has been minimized.

Copy link

commented Feb 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3e9c4ab

https://deploy-preview-12548--kubernetes-io-master-staging.netlify.com

@remyleone

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

I've signed the individual agreement

@Rajakavitha1

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

/assign @xiangpengzhao

@remyleone remyleone force-pushed the remyleone:language_fr branch from 52fdcf8 to ca5332f Feb 8, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/S labels Feb 8, 2019

@remyleone

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

@perriea @rekcah78 @lledru @yastij @Smana @rbenzair would like to contribute as well to the French translation.

@remyleone remyleone force-pushed the remyleone:language_fr branch 5 times, most recently from 30f50cc to 97a6815 Feb 11, 2019

@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels Feb 11, 2019

@remyleone remyleone force-pushed the remyleone:language_fr branch 4 times, most recently from 5677e2b to db3570a Feb 11, 2019

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

/assign @zacharysarah

README-fr.md Outdated Show resolved Hide resolved

@remyleone remyleone force-pushed the remyleone:language_fr branch from db3570a to 88234ae Feb 12, 2019

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@lucperkins 👋 Do you mind reviewing this for a LGTM?

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@sieben

I think I've added the relevant block to config.toml
Could you tell me what is missing?

It looks good to me. 💯

@remyleone

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

How could it be merged now?

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@sieben Just waiting on approval from a second reviewer. I've tagged @lucperkins; he'll get to it as his time permits.

@remyleone remyleone referenced this pull request Feb 12, 2019
6 of 6 tasks complete

@remyleone remyleone force-pushed the remyleone:language_fr branch from 02420e9 to a7dff9b Feb 13, 2019

@yastij

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

/hold

until @lucperkins reviews, I'll try to do a pass also on this.

@zparnold

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@remyleone remyleone force-pushed the remyleone:language_fr branch from a7dff9b to 1bd8e37 Feb 13, 2019

@remyleone remyleone force-pushed the remyleone:language_fr branch from 1bd8e37 to 3e9c4ab Feb 13, 2019

@perriea perriea referenced this pull request Feb 13, 2019
6 of 6 tasks complete
@remyleone

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@yastij I think @lucperkins did a review previously.

@lucperkins

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

LGTM

Or perhaps more appropriately TTBT (très très bon travail)

@yastij
yastij approved these changes Feb 13, 2019
Copy link
Member

left a comment

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Feb 13, 2019

@k8s-ci-robot k8s-ci-robot merged commit a5cda6e into kubernetes:master Feb 13, 2019

7 of 8 checks passed

Pages changed 2 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 505 redirect rules processed
Details
cla/linuxfoundation sieben authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
tide In merge pool.
Details
kwiesmueller added a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
krmayankk added a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
yagonobre added a commit to yagonobre/website that referenced this pull request Mar 14, 2019

@remyleone remyleone deleted the remyleone:language_fr branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.