Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init German translation #13340

Merged
merged 7 commits into from Mar 26, 2019

Conversation

@bene2k1
Copy link
Member

commented Mar 22, 2019

Init of the German translation of the Kubernetes documentation / Website

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Mar 22, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bene2k1

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

I've signed the individual agreement

@remyleone

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@zacharysarah @bene2k1 is a colleague. We work together @scaleway . I can provide guidance and volunteer to speed up the process to create a German translating community.

@netlify

This comment has been minimized.

Copy link

commented Mar 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 31822a1

https://deploy-preview-13340--kubernetes-io-master-staging.netlify.com

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

/check-cla

@rlenferink
Copy link
Member

left a comment

Thanks for initiating the German translation 🎉
I've got some feedback on this PR.

It is good to have binaries removed if they don't differ from the English documentation.
Can you remove:

content/de/_common-resources/images/blocks.png
content/de/_common-resources/images/flower.png
content/de/_common-resources/images/kub_video_banner_homepage.jpg
content/de/_common-resources/images/scalable.png
content/de/_common-resources/images/suitcase.png

Compliments on your writing though. Looks good!

Show resolved Hide resolved content/de/docs/concepts/overview/what-is-kubernetes.md Outdated
Show resolved Hide resolved content/de/includes/partner-script.js Outdated
Show resolved Hide resolved content/de/includes/partner-style.css Outdated
Show resolved Hide resolved content/de/includes/task-tutorial-prereqs.md Outdated
Show resolved Hide resolved content/de/includes/user-guide-content-moved.md Outdated
Show resolved Hide resolved content/de/includes/user-guide-migration-notice.md Outdated
@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@bene2k1 Welcome to Kubernetes docs! 👋 Would you please verify that you’ve signed the CLA? It’s a requirement before we can proceed. Thanks in advance!

@k8s-ci-robot k8s-ci-robot added size/XL and removed size/XXL labels Mar 22, 2019

@bene2k1

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

Should be OK for the CLA now.

@zacharysarah
Copy link
Contributor

left a comment

@bene2k1 Good start. Here's some feedback.

Show resolved Hide resolved OWNERS_ALIASES
@rlenferink

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

/language de


* June Yi ([GitHub - @gochist](https://github.com/gochist))
* [Slack Kanal](https://kubernetes.slack.com/messages/kubernetes-docs-ko)

This comment has been minimized.

Copy link
@sftim

sftim Mar 23, 2019

Contributor

Vielleicht auch Deutsche hinzufügen?

This comment has been minimized.

Copy link
@rlenferink

rlenferink Mar 23, 2019

Member

Thanks for the suggestion. This is definitely a good idea and something which is good to have updated indeed as only the Korean localization is listed right now.

It may be good to update it in a separate PR (and maybe start with the English README.md for formatting and then ping the different translations) and just get the initial translation started for now.

@bene2k1 bene2k1 referenced this pull request Mar 25, 2019

Closed

REQUEST: New membership for bene2k1 #648

6 of 6 tasks complete

bene2k1 added some commits Mar 26, 2019

@rlenferink

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

/lgtm
@zacharysarah for approval

Thanks for starting this @bene2k1 🎉

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@bene2k1 Thanks for beginning a German localization! Welcome to Kubernetes! 🎉

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Mar 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a5ddc03 into kubernetes:master Mar 26, 2019

6 of 8 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
Pages changed 8 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 505 redirect rules processed
Details
cla/linuxfoundation bene2k1 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

## Beiträge zur Dokumentation

Sie können auf die Schaltfläche **Fork** im oberen rechten Bereich des Bildschirms klicken, um eine Kopie dieses Repositorys in Ihrem GitHub-Konto zu erstellen. Diese Kopie wird als *Fork* bezeichnet. Nehmen Sie die gewünschten Änderungen an Ihrem Fork vor. Wenn Sie bereit sind, diese Änderungen an uns zu senden, gehen Sie zu Ihrem Form und erstellen Sie eine neue Pull-Anforderung, um uns darüber zu informieren.

This comment has been minimized.

Copy link
@jmara

jmara Mar 29, 2019

Form soll sicher Fork heißen oder?

@girikuncoro girikuncoro referenced this pull request Apr 13, 2019

Draft

Init Indonesian translation #1

4 of 4 tasks complete

@bene2k1 bene2k1 deleted the bene2k1:init_german_translation branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.