Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain Kubernetes auditing with Falco #14332

Merged
merged 1 commit into from Aug 20, 2019
Merged

Explain Kubernetes auditing with Falco #14332

merged 1 commit into from Aug 20, 2019

Conversation

leodido
Copy link
Contributor

@leodido leodido commented May 15, 2019

Example on how to use the CNCF Falco project to do Kubernetes auditing.

Here an asciinema showing the described steps.

asciicast

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 15, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 15, 2019
@netlify
Copy link

netlify bot commented May 15, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit af9329e

https://deploy-preview-14332--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented May 15, 2019 •
edited

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8176441

https://deploy-preview-14332--kubernetes-io-master-staging.netlify.com

@fntlnz
Copy link
Contributor

fntlnz commented May 15, 2019

/assign @stewart-yu

sftim
sftim reviewed May 19, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing informally.
I hope these suggestions & comments are helpful.

content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
radhikapc
radhikapc reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@radhikapc radhikapc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for

  • Completeness
  • Clarity
  • Punctuation
  • Conciseness

content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2019
@zacharysarah
Copy link
Contributor

@leodido 👋 Thanks for this PR. Unfortunately, this content isn't suitable for K8s docs because:

  1. It's dual-sourced content.

    This content looks like a great addition/update to the Falco docs.

  2. It asks k/website to host content from a project outside the kubernetes or kubernetes-sigs GitHub organizations.

These requirements aren't currently documented in our style guide. Sorry about that! I've opened #15576 to ensure that we correctly document these restrictions.

/close

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Closed this PR.

In response to this:

@leodido 👋 Thanks for this PR. Unfortunately, this content isn't suitable for K8s docs because:

  1. It's dual-sourced content.

    This content looks like a great addition/update to the Falco docs.

  2. It asks k/website to host content from a project outside the kubernetes or kubernetes-sigs GitHub organizations.

These requirements aren't currently documented in our style guide. Sorry about that! I've opened #15576 to ensure that we correctly document these restrictions.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zacharysarah
Copy link
Contributor

@leodido I owe you an apology; I didn't realize that Falco is a CNCF incubator project. Given that Falco's in the incubator, it meets standards for inclusion with some feedback. (I'll leave a separate review shortly.)

Sorry! 🙇

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Aug 9, 2019
@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Reopened this PR.

In response to this:

@leodido I owe you an apology; I didn't realize that Falco is a CNCF incubator project. Given that Falco's in the incubator, it meets standards for inclusion with some feedback. (I'll leave a separate review shortly.)

Sorry! 🙇

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zacharysarah
zacharysarah reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leodido This is well-written and clear. ✨Some nits, otherwise LGTM. 🚀

content/en/docs/tasks/debug-application-cluster/audit.md Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Show resolved Hide resolved
content/en/docs/tasks/debug-application-cluster/audit.md Outdated Show resolved Hide resolved
@zacharysarah
Copy link
Contributor

@radhikapc @thecrudge Sorry for the confusion! I owe you beverages at the next KubeCon. 🍻

@zacharysarah
Copy link
Contributor

@leodido Please remove the excess whitespace and squash your commits so we can proceed. 😄

@zacharysarah
Copy link
Contributor

@thecrudge @radhikapc 👋 Would you please poke @leodido to respond? I'd hate to close this PR again because it went inactive. 😳

@thecrudge
Copy link
Contributor

thecrudge commented Aug 19, 2019 via email •
edited

@leodido
Copy link
Contributor Author

leodido commented Aug 20, 2019

@zacharysarah sorry I was on vacation with little access to the internet. I'm going to fix the excess white spaces and squash the commits today!

@leodido @fntlnz
@sftim @radhikapc
Explain auditing with Falco
8176441 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Tim Bannister <tim@scalefactory.com>
Co-Authored-By: Radhika Puthiyetath <radhika.dwaraka@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2019
@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@zacharysarah
Copy link
Contributor

@leodido Congratulations! 🎉

@k8s-ci-robot k8s-ci-robot merged commit 21e9164 into kubernetes:master Aug 20, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@leodido @fntlnz
@sftim @radhikapc @wahyuoi
Explain auditing with Falco (kubernetes#14332)
8ac6f73 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Tim Bannister <tim@scalefactory.com>
Co-Authored-By: Radhika Puthiyetath <radhika.dwaraka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah left review comments

@radhikapc radhikapc radhikapc left review comments

@sftim sftim sftim left review comments

@ericchiang ericchiang Awaiting requested review from ericchiang

@sttts sttts Awaiting requested review from sttts

Assignees

@zacharysarah zacharysarah

@stewart-yu stewart-yu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@leodido @k8s-ci-robot @fntlnz @zacharysarah @thecrudge @radhikapc @sftim @stewart-yu