Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-trans: add docs/setup/best-practices/node-conformance.md #15804

Merged

Conversation

@SataQiu
Copy link
Member

commented Aug 11, 2019

No description provided.

-->

* 测试会在节点上遗留一些 Docker 镜像, 包括节点一致性测试本身的镜像和功能测试相关的镜像。
* 测试会在节点上遗留一些死的容器。这些容器是在功能测试的过程中创建的。

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Aug 11, 2019

Member
Suggested change
* 测试会在节点上遗留一些死的容器。这些容器是在功能测试的过程中创建的。
* 测试会在节点上遗留一些废用的容器。这些容器是在功能测试的过程中创建的。
@chenrui333
Copy link
Member

left a comment

lgtm with some suggestions

SataQiu and others added some commits Aug 13, 2019

Update content/zh/docs/setup/best-practices/node-conformance.md
Co-Authored-By: chenrui <rui@meetup.com>
Update content/zh/docs/setup/best-practices/node-conformance.md
Co-Authored-By: chenrui <rui@meetup.com>
Update content/zh/docs/setup/best-practices/node-conformance.md
Co-Authored-By: chenrui <rui@meetup.com>
Update content/zh/docs/setup/best-practices/node-conformance.md
Co-Authored-By: chenrui <rui@meetup.com>
@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Thanks @chenrui333 Updated 😄

@chenrui333
Copy link
Member

left a comment

/lgtm

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9370222 into kubernetes:release-1.14 Aug 13, 2019

5 of 7 checks passed

tide Not mergeable. Needs approved label.
Details
Pages changed 317 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
cla/linuxfoundation SataQiu authorized
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.