Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-tran-ahanabi-5 #16603

Open
wants to merge 19 commits into
base: release-1.14
from

Conversation

@ahanabi
Copy link

commented Sep 29, 2019

No description provided.

ahanabi and others added 18 commits Sep 8, 2019
…ting-contributor-experience.md

Co-Authored-By: LiuDui <1693291525@qq.com>
…ting-contributor-experience.md

Co-Authored-By: LiuDui <1693291525@qq.com>
…ting-contributor-experience.md

Co-Authored-By: LiuDui <1693291525@qq.com>
…ting-contributor-experience.md

Co-Authored-By: LiuDui <1693291525@qq.com>
…ting-contributor-experience.md

Co-Authored-By: LiuDui <1693291525@qq.com>
…ting-contributor-experience.md

Co-Authored-By: LiuDui <1693291525@qq.com>
…ting-contributor-experience.md

Co-Authored-By: LiuDui <1693291525@qq.com>
…ontrollers-With-Puppet.md
…ontrollers-With-Puppet.md
…ontrollers-With-Puppet.md
…ence.md
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

@ahanabi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

/assign

@chenrui333

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@ahanabi ping

@markthink

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

/hold
@ahanabi ping 需要解决冲突

@ahanabi ahanabi changed the base branch from release-1.14 to release-1.16 Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/L labels Oct 10, 2019
@ahanabi ahanabi changed the base branch from release-1.16 to release-1.14 Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/XXL labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.