Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content/es/docs/reference/glossary/sig.md #17147

Merged
merged 1 commit into from Nov 2, 2019

Conversation

@atsuky
Copy link
Contributor

atsuky commented Oct 23, 2019

Add a new page of the glossay :)

@atsuky

This comment has been minimized.

Copy link
Contributor Author

atsuky commented Oct 23, 2019

/assign @raelga

@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 23, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c9c0666

https://deploy-preview-17147--kubernetes-io-master-staging.netlify.com

Copy link
Member

raelga left a comment

Muchas gracias @atsuky!

He añadido algunas propuestas en la review, échale un ojo a ver que te parecen.

Un saludo,

content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/sig.md Outdated Show resolved Hide resolved
@atsuky atsuky force-pushed the atsuky:add-sig-glossary-page branch from eeeb747 to 2020675 Oct 31, 2019
@atsuky

This comment has been minimized.

Copy link
Contributor Author

atsuky commented Oct 31, 2019

@raelga Suggestions applied, no sabía que había que traducir los "enlaces" a otras referencias del glosario sorry!

He hecho squash de los commits :)

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <rael@rael.io>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <rael@rael.io>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <rael@rael.io>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <rael@rael.io>

Update content/es/docs/reference/glossary/sig.md

Co-Authored-By: Rael Garcia <rael@rael.io>

Solve YAML identation errors
@atsuky atsuky force-pushed the atsuky:add-sig-glossary-page branch from 2020675 to c9c0666 Oct 31, 2019
@atsuky

This comment has been minimized.

Copy link
Contributor Author

atsuky commented Oct 31, 2019

Revisados los errores de identación en el yaml, ahora si que funciona correctamente

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 1, 2019

Muchas gracias por los cambios, por mi parte:

/lgtm

Podéis echarle un vistazo @electrocucaracha o @alexbrand ? :)

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 1, 2019
@raelga
raelga approved these changes Nov 1, 2019
@alexbrand

This comment has been minimized.

Copy link
Member

alexbrand commented Nov 1, 2019

LGTM! Gracias @atsuky

/lgtm

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 2, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d20f20 into kubernetes:master Nov 2, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Needs approved label.
Details
Pages changed 348 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 504 redirect rules processed
Details
cla/linuxfoundation atsuky authorized
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.