Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content/es/docs/reference/glossary/container-runtime.md #17175

Open
wants to merge 1 commit into
base: master
from

Conversation

@javisabalete
Copy link
Contributor

javisabalete commented Oct 24, 2019

He optado por no traducir Container Runtime a pesar de que Runtime lo he visto en el spanish style guide-glossary, no me sonaba bien

@k8s-ci-robot k8s-ci-robot requested review from electrocucaracha and raelga Oct 24, 2019
@javisabalete javisabalete changed the title Add es/docs/reference/glossary/container-runtime.md Add content/es/docs/reference/glossary/container-runtime.md Oct 24, 2019
@javisabalete javisabalete force-pushed the javisabalete:container-runtime-es branch from 169b321 to 110c39f Oct 24, 2019
@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 24, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 169b321

https://deploy-preview-17175--kubernetes-io-master-staging.netlify.com

@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 24, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 32f453b

https://deploy-preview-17175--kubernetes-io-master-staging.netlify.com

@raelga raelga self-assigned this Oct 26, 2019
Copy link
Member

raelga left a comment

Muchas gracias @javisabalete!

En la review solo he añadido el término en castellano cuando se introduce por primera vez Container Runtime, y a partir de ahí dejado el término original en inglés pero con cursiva. A ver qué te parece :)

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 6, 2019

@javisabalete has podido revisar la review?

Muchas gracias!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign raelga
You can assign the PR to them by writing /assign @raelga in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@javisabalete javisabalete force-pushed the javisabalete:container-runtime-es branch from eedb27c to 9be2ae1 Nov 11, 2019
@javisabalete

This comment has been minimized.

Copy link
Contributor Author

javisabalete commented Nov 11, 2019

Rebase listo :+1

@electrocucaracha

This comment has been minimized.

Copy link
Contributor

electrocucaracha commented Nov 13, 2019

/lgtm

Copy link
Member

raelga left a comment

Falta una identanción en short_description tras el : >:

Screenshot 2019-11-18 at 15 05 21

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 18, 2019

/hold

Hasta solucionar el problema de compilación.

@javisabalete javisabalete force-pushed the javisabalete:container-runtime-es branch from 001cb82 to 32f453b Nov 19, 2019
@javisabalete javisabalete requested review from electrocucaracha and raelga Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.