Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content/es/docs/reference/glossary/label.md #17218

Merged
merged 6 commits into from Nov 8, 2019
Merged

Conversation

@k4ch0
Copy link
Contributor

k4ch0 commented Oct 27, 2019

New page translation: content/es/docs/reference/glossary/label.md

Tracked:
Issue:#13948
Comment: #13948 (comment)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 27, 2019

Welcome @k4ch0!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 27, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 27, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b90aae9

https://deploy-preview-17218--kubernetes-io-master-staging.netlify.com

@k4ch0

This comment has been minimized.

Copy link
Contributor Author

k4ch0 commented Oct 29, 2019

I signed it

1 similar comment
@k4ch0

This comment has been minimized.

Copy link
Contributor Author

k4ch0 commented Oct 29, 2019

I signed it

@raelga raelga self-assigned this Oct 30, 2019
Copy link
Member

raelga left a comment

Muchas gracias por la contribución y bienvenido a Kubernetes! 🎉

Le he dado una vuelta a la definición de label, a ver que te parece.

Podéis echarle un ojo también @electrocucaracha y @glo-pena?

content/es/docs/reference/glossary/label.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/label.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/label.md Outdated Show resolved Hide resolved
content/es/docs/reference/glossary/label.md Outdated Show resolved Hide resolved
k4ch0 and others added 4 commits Oct 30, 2019
Co-Authored-By: Rael Garcia <rael@rael.io>
Co-Authored-By: Rael Garcia <rael@rael.io>
Co-Authored-By: Rael Garcia <rael@rael.io>
Co-Authored-By: Rael Garcia <rael@rael.io>
@k4ch0

This comment has been minimized.

Copy link
Contributor Author

k4ch0 commented Nov 3, 2019

@raelga, do I need to do anything else?

Copy link
Member

raelga left a comment

Buenas lo que comento en la revisión, parece que el Build está fallando por alguno de esos dos motivos. Si le puedes echar un ojo lo arreglamos y publicamos el contenido. :)

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 3, 2019

The build is failing, holding to avoid accidental merge.

/hold

Fixing the section short_description adding a tab on the text
Copy link
Contributor Author

k4ch0 left a comment

Agrege la identacion en la seccion previa

@k4ch0

This comment has been minimized.

Copy link
Contributor Author

k4ch0 commented Nov 4, 2019

Fixed indentation!

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 4, 2019

/hold cancel

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 4, 2019

Muchas gracias!

Por mí parte
/lgtm

A ver si tenemos una segunda revisión de @glo-pena, @electrocucaracha o @alexbrand y lo publicamos si está todo bien.

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 4, 2019
@raelga
raelga approved these changes Nov 6, 2019
@alexbrand

This comment has been minimized.

Copy link
Member

alexbrand commented Nov 8, 2019

Se ve bien! Gracias @k4ch0.
/lgtm

@raelga

This comment has been minimized.

Copy link
Member

raelga commented Nov 8, 2019

Gracias a los dos!

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 580b1d6 into kubernetes:master Nov 8, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Needs approved label.
Details
Pages changed 2271 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 505 redirect rules processed
Details
cla/linuxfoundation k4ch0 authorized
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.