Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fale to IT approvers #23098

Merged

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Aug 12, 2020

As per slack discussion https://kubernetes.slack.com/archives/CGB1MCK7X/p1597166062151500, adding @Fale as IT approvers

xref kubernetes/org#2100

/language it
/assing @rlenferink
/cc @Fale

@k8s-ci-robot k8s-ci-robot requested a review from Fale August 12, 2020 09:11
@k8s-ci-robot k8s-ci-robot added language/it Issues or PRs related to Italian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2020
@fabriziopandini
Copy link
Member Author

/assign @rlenferink

@rlenferink
Copy link
Member

/lgtm
Good to on-board an additional active contributor :)

/assign @sftim
for approval

(I am not root approver so we have to delegate here :) )

@Fale
Copy link
Member

Fale commented Aug 12, 2020

Thanks a lot :-)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@netlify
Copy link

netlify bot commented Aug 12, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5f19ac2

https://deploy-preview-23098--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Aug 12, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit e9667d3 into kubernetes:master Aug 12, 2020
@fabriziopandini fabriziopandini deleted the add-fale-to-IT-approvers branch August 13, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/it Issues or PRs related to Italian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants