[zh] translate tutorial guestbook-logs-metrics-with-elk #24662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
sig/docs
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 98d9ac5 https://deploy-preview-24662--kubernetes-io-master-staging.netlify.app |
15 tasks
|
/retitle [zh] translate tutorial guestbook-logs-metrics-with-elk |
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
tengqm
reviewed
Oct 22, 2020
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Show resolved
Hide resolved
|
Overall looks good. |
|
@zhiguo-lu since #24675 is in, please help rebase your PR onto the master for a resync. |
好的，很高兴收到你的comment和提醒。 |
tengqm
reviewed
Oct 23, 2020
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
content/zh/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
Outdated
Show resolved
Hide resolved
make change acording to tengqm's comment and rebase to 24675 change against tengqm's second round comment
|
谢谢订正。 |
|
/approve |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: beac61dc75ef7e6477db92be5ea1427fb14bf33d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markthink, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate tutorial guestbook-logs-metrics-with-elk into Chinese.
close #24505