Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation about Endpoints write access in wake of CVE-2021-25740 #29025

Merged
merged 1 commit into from Jul 27, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Jul 20, 2021

This is a follow up to kubernetes/kubernetes#103704 (comment) and the mitigation of kubernetes/kubernetes#103675. @liggitt suggested that I pull the YAML example he provided out of the release note and into RBAC docs. I'm not sure if this is the right place - suggestions very welcome.

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2021
@netlify
Copy link

netlify bot commented Jul 20, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: d710925

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60feffbc38292a0007028897

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from deads2k and liggitt Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 20, 2021
Copy link
Contributor

@sftim sftim left a comment

/sig auth

Some feedback on the documentation style. It's OK to merge without addressing these.

content/en/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jul 20, 2021
sftim
sftim previously requested changes Jul 21, 2021
content/en/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
@enj enj added this to Needs Triage in SIG Auth Jul 21, 2021
@robscott robscott force-pushed the endpoints-rbac branch 2 times, most recently from bbb50f8 to 36c4a57 Compare Jul 21, 2021
@sftim sftim dismissed their stale review Jul 26, 2021

Fixed!

SIG Auth automation moved this from Needs Triage to Changes Requested (v1.22) Jul 26, 2021
@PI-Victor
Copy link
Member

PI-Victor commented Jul 26, 2021

anything else to add, or can we go ahead and merge this?

@robscott
Copy link
Member Author

robscott commented Jul 26, 2021

@PI-Victor I think this is good to go, I don't have anything else to add at least.

@PI-Victor
Copy link
Member

PI-Victor commented Jul 26, 2021

thank you!
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 27, 2021

LGTM label has been added.

Git tree hash: 4db2b28292d3843a0ea0dea36d905d79e1cc7b63

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit acc7252 into kubernetes:dev-1.22 Jul 27, 2021
6 of 7 checks passed
SIG Auth automation moved this from Changes Requested (v1.22) to Closed / Done Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm Indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Auth
Closed / Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants