Skip to content

[en] Fix Markdown formats - #32897

Merged
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
Sea-n:main
Apr 15, 2022
Merged

k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
Sea-n:main

Conversation

@Sea-n

@Sea-n Sea-n commented Apr 13, 2022 •

Copy link
Copy Markdown
Member

@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 13, 2022 •

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Sea-n / name: Sean (3c61421)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 13, 2022
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @Sea-n!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2022
@k8s-ci-robot
k8s-ci-robot requested a review from chenxuc April 13, 2022 13:14
@k8s-ci-robot k8s-ci-robot added the language/de Issues or PRs related to German language label Apr 13, 2022
@k8s-ci-robot
k8s-ci-robot requested a review from deads2k April 13, 2022 13:14
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 13, 2022
@netlify

netlify Bot commented Apr 13, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 01c3c53
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/625709aba4605100089765f3
😎 Deploy Preview https://deploy-preview-32897--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 13, 2022
@sftim

sftim commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

@Sea-n Please limit pull requests to a single localization, since pull requests that change content in multiple localizations are difficult to review.

I suggest that you start with just the English changes that you wanted to make, and then open a separate PR for each localization that you want to update. We want separate PRs partly to allow sharing out the work, but mostly because I think we don't have any reviewers who speak all 13 languages that we've localized the docs into.

@sftim

sftim commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

/hold
OK to /unhold once this PR only touches one localization.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2022
This was referenced Apr 13, 2022
@Sea-n Sea-n changed the title Fix Markdown formats [en] Fix Markdown formats Apr 13, 2022
@Sea-n

Sea-n commented Apr 13, 2022 •

Copy link
Copy Markdown
Member Author

Thanks very much for point out my mistake in the original PR! I have break it down to 8 separated branch for different language.

Here is PR for en, zh, it.
For id, fr, es, pt-br, de, I will open PR after your think it's okay.

CC @sftim

@jihoon-seo

Copy link
Copy Markdown
Member

/unhold
/remove-language de es fr id it zh

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot removed language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/zh Issues or PRs related to Chinese language labels Apr 14, 2022
@Sea-n

Sea-n commented Apr 14, 2022

Copy link
Copy Markdown
Member Author

/auto-cc

@k8s-ci-robot
k8s-ci-robot requested a review from davidopp April 14, 2022 15:28
@Sea-n

Sea-n commented Apr 14, 2022

Copy link
Copy Markdown
Member Author

/assign @bradtopol

The previously assigned reviewer seems busy with other projects, could you help this PR to push some progress? 🙇‍♂️

@tengqm

tengqm commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

This is clean.
/kind cleanup
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 15, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2022
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 6e15663545bb9815f2875550170e11f7b123825b

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2022
@k8s-ci-robot
k8s-ci-robot merged commit 6fb52c5 into kubernetes:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants