Skip to content

Sync community-values.md from k/community - #34311

Merged
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
Sea-n:sync-values
Jun 17, 2022
Merged

Sync community-values.md from k/community#34311
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
Sea-n:sync-values

Conversation

@Sea-n

@Sea-n Sea-n commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Apply changes from January 2021.

Add similar text adopted from /content/en/comm/coc.md to link to the canonical version.

Netlify preview: https://deploy-preview-34311--kubernetes-io-main-staging.netlify.app/community/values

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2022
@k8s-ci-robot
k8s-ci-robot requested a review from bradtopol June 15, 2022 17:55
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 15, 2022
@netlify

netlify Bot commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 34311fe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62aab9b22ad3680009d2a160
😎 Deploy Preview https://deploy-preview-34311--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zacharysarah
zacharysarah approved these changes Jun 16, 2022
View reviewed changes

@zacharysarah zacharysarah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sea-n Thanks for updating this. ✨

The preview now centers body text, but I don't see any formatting or CSS changes. It's not blocking, just noticeable. 🤷🏻

Otherwise LGTM

@zacharysarah

zacharysarah commented Jun 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm willing to give an LGTM but would prefer a co-chair perform the approval. 👋🏻

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@k8s-ci-robot

k8s-ci-robot commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 365e50849fdf7b8ad7299bbdb47a30bb1a9c17ac

@zacharysarah

zacharysarah commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

/assign @natalisucks @reylejano @divya-mohan0209

@zacharysarah zacharysarah removed their assignment Jun 16, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@Sea-n

Sea-n commented Jun 16, 2022

Copy link
Copy Markdown
Member Author

Oh, thanks @zacharysarah for pointing the style mismatch out!

I've fixed that, waiting for others to review.

@zacharysarah

zacharysarah commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot

k8s-ci-robot commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 6a553625c4d02daf5950689086544cd1d043fe82

divya-mohan0209
divya-mohan0209 reviewed Jun 17, 2022
View reviewed changes

@divya-mohan0209 divya-mohan0209 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this to our attention @zacharysarah and thank you so much for fixing this @Sea-n !
/approve

@k8s-ci-robot

k8s-ci-robot commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@k8s-ci-robot
k8s-ci-robot merged commit 93a4a5a into kubernetes:main Jun 17, 2022
@Sea-n
Sea-n deleted the sync-values branch July 22, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments
@bradtopol bradtopol Awaiting requested review from bradtopol
@natalisucks natalisucks Awaiting requested review from natalisucks
@reylejano reylejano Awaiting requested review from reylejano
+1 more reviewer
@zacharysarah zacharysarah zacharysarah approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@zacharysarah zacharysarah

@natalisucks natalisucks

@divya-mohan0209 divya-mohan0209

@reylejano reylejano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Sea-n @zacharysarah @k8s-ci-robot @divya-mohan0209 @natalisucks @reylejano