Fix link for TLS bootstrapping #34722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I believe #34381 is already fixing one of the pages, but it is not reviewed yet. |
|
Oh, sorry for missed that. Hold until #34381 merged and rebase this one. |
k8s-ci-robot
added
the
do-not-merge/hold
Sea-n
force-pushed
the
fix-kubelet-tls-links
branch
from
34722bb to
34722ab
Compare
k8s-ci-robot
added
size/XS
|
The PR #34381 is finally merged. The reformat is already done, this PR now have only one commit. |
k8s-ci-robot
removed
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4a02e03890d99e44f241b4de155a664a13ae9a34
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit do the minimal reformat for(It's done by #34381)implementation-details.mdfile. (Only adjust spaces)The second commit replaced two invalid links for TLS Bootstrapping. (ref: PR #33130)
Checked visually the same (with intended space changes).
Preview: https://deploy-preview-34722--kubernetes-io-main-staging.netlify.app/docs/reference/setup-tools/kubeadm/implementation-details/
Production: https://kubernetes.io/docs/reference/setup-tools/kubeadm/implementation-details/
/kind cleanup
/label tide/merge-method-squash