Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fr] Fix a link in concepts/architecture/nodes.md #35097

Merged
merged 1 commit into from Jan 10, 2023
Merged

[fr] Fix a link in concepts/architecture/nodes.md #35097

merged 1 commit into from Jan 10, 2023

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Jul 17, 2022 •
edited

Fix a link

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2022
@k8s-ci-robot k8s-ci-robot added the language/fr Issues or PRs related to French language label Jul 17, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 17, 2022
@netlify
Copy link

netlify bot commented Jul 17, 2022 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ea64ed2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6379cccebeda4e0009cad393
😎 Deploy Preview https://deploy-preview-35097--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@windsonsea
Copy link
Member Author

/retest

Sea-n
Sea-n reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3b49616a7f0be3291dd5d468e692b3caf0b9c5da

@rekcah78
Copy link
Contributor

/approval

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2022
@windsonsea windsonsea changed the title [fr] Fix links for k/design-proposals-archive [fr] Fix a link in concepts/architecture/nodes.md Nov 20, 2022
@natalisucks
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f4e4a5a35bb6e4e845929889ca40f31bf1c591b3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 55eed05 into kubernetes:main Jan 10, 2023
1 check passed
@windsonsea windsonsea deleted the designfr branch January 16, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jygastaud jygastaud Awaiting requested review from jygastaud

@rekcah78 rekcah78 Awaiting requested review from rekcah78

@Sea-n Sea-n Awaiting requested review from Sea-n

Assignees

@Sea-n Sea-n

@natalisucks natalisucks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@windsonsea @k8s-ci-robot @rekcah78 @natalisucks @Sea-n