Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference to file name in generated configMap #39209

Merged
merged 1 commit into from Mar 13, 2023
Merged

Fix reference to file name in generated configMap #39209

merged 1 commit into from Mar 13, 2023

Conversation

wfhartford
Copy link
Contributor

Documentation prose refers to the file named .properties, the correct file name is application.properties.

@wfhartford
Fix reference to file name in generated configMap
b15ead7 
Documentation prose refers to the file named `.properties`, the correct file name is `application.properties`.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 1, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wfhartford / name: Wesley Hartford (b15ead7)

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 1, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @wfhartford!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 1, 2023
@netlify
Copy link

netlify bot commented Feb 1, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b15ead7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63da8b98cfd3ea00080d2ab2
😎 Deploy Preview https://deploy-preview-39209--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Shubham82
Shubham82 reviewed Feb 2, 2023
View reviewed changes
content/en/docs/tasks/manage-kubernetes-objects/kustomization.md
@@ -120,7 +120,7 @@ metadata:
```

{{< note >}}
Each variable in the `.env` file becomes a separate key in the ConfigMap that you generate. This is different from the previous example which embeds a file named `.properties` (and all its entries) as the value for a single key.
Each variable in the `.env` file becomes a separate key in the ConfigMap that you generate. This is different from the previous example which embeds a file named `application.properties` (and all its entries) as the value for a single key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the docs is correct, here is it mentioned as a file extension.

@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc5355d6872405d937956f3533e6766182020b97

@mehabhalodiya
Copy link
Contributor

/lgtm

@tengqm
Copy link
Contributor

tengqm commented Mar 13, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 94a8fcf into kubernetes:main Mar 13, 2023
@windsonsea windsonsea mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubham82 Shubham82 Shubham82 left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@sftim sftim Awaiting requested review from sftim

Assignees

@kbhawkey kbhawkey

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wfhartford @k8s-ci-robot @kbhawkey @mehabhalodiya @tengqm @Shubham82