New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronJobs aren't enabled in 1.6 by default #4185

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
6 participants
@outcoldman
Copy link
Contributor

outcoldman commented Jun 25, 2017

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.


This change is Reviewable

@soltysh
Copy link
Contributor

soltysh left a comment

LGTM

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Jun 26, 2017

@outcoldman mind updating the PR?

@outcoldman

This comment has been minimized.

Copy link
Contributor Author

outcoldman commented Jun 26, 2017

@soltysh, sure! What needs to be updated?

@outcoldman outcoldman force-pushed the outcoldman:patch-1 branch from 19754ec to 56ca738 Jun 26, 2017

@outcoldman

This comment has been minimized.

Copy link
Contributor Author

outcoldman commented Jun 26, 2017

@soltysh rebased (looked from mobile phone first, and did not see that it needed a rebase)

@chenopis chenopis merged commit 8716e15 into kubernetes:master Jun 26, 2017

3 checks passed

cla/linuxfoundation outcoldman authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@outcoldman outcoldman deleted the outcoldman:patch-1 branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment