Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the incorrect label in kubectl command for inspecting Leases for kube-apiserver #42086

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Correct the incorrect label in kubectl command for inspecting Leases for kube-apiserver #42086

merged 1 commit into from
Aug 1, 2023

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Jul 19, 2023

This fixes #41881

Corrected the incorrect(old) label in kubectl command for inspecting Leases for kube-apiserver.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Affan-7 / name: Mohammed Affan (b2aa1c7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Affan-7!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim July 19, 2023 10:34
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b2aa1c7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64b7dece5dd25f0008f9d480
😎 Deploy Preview https://deploy-preview-42086--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Affan-7 Affan-7 marked this pull request as draft July 19, 2023 11:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2023
@Affan-7 Affan-7 marked this pull request as ready for review July 19, 2023 12:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2023
@Affan-7 Affan-7 changed the title Update leases.md Correct the incorrect label in kubectl command for inspecting Leases for kube-apiserver Jul 19, 2023
@Affan-7
Update leases.md
b2aa1c7 
Corrected the incorrect(old) label in kubectl command for inspecting Leases for kube-apiserver
@Affan-7 Affan-7 marked this pull request as draft July 20, 2023 05:27
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@Affan-7 Affan-7 marked this pull request as ready for review July 20, 2023 05:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
sftim
sftim reviewed Jul 23, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/sig api-machinery

No tech review needed, but an extra check is appreciated.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54eee72982f5e73dbf94de5a62df2f788581f92d

@mehabhalodiya
Copy link
Contributor

/lgtm

@Affan-7 Affan-7 requested a review from sftim July 28, 2023 04:46
@Affan-7
Copy link
Contributor Author

Affan-7 commented Jul 31, 2023

Hi @sftim, can you please merge this?

@tengqm
Copy link
Contributor

tengqm commented Aug 1, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit e0b70d8 into kubernetes:main Aug 1, 2023
4 checks passed
@ydFu ydFu mentioned this pull request Aug 1, 2023
Merged
@Affan-7 Affan-7 deleted the Correct-the-label branch August 1, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@tengqm tengqm Awaiting requested review from tengqm

@natalisucks natalisucks Awaiting requested review from natalisucks

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect label in kubectl command for inspecting Leases for kube-apiserver
5 participants
@Affan-7 @k8s-ci-robot @mehabhalodiya @tengqm @sftim