-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Translate data plane definition #46555
[ja] Translate data plane definition #46555
Conversation
cc @Okabe-Junya |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!!
I made a few comments, PTAL :)
/retitle [ja] Translate data plane definition |
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thank you!
/lgtm
/assign inductor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the inconvenience, but I have further reviewed this translation and would like to request a few simple fixes.
(Note that this is a part of the glossary, so a very high-quality translation is required.)
/lgtm cancel
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
/lgtm
LGTM label has been added. Git tree hash: 28f7497118737b78fad6ea712feacf5916342310
|
/label tide/merge-method-squash |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inductor, Okabe-Junya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Data plane definition in JA * Data plane definition in JA * accepted review Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> * Update content/ja/docs/reference/glossary/data-plane.md Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> * Update content/ja/docs/reference/glossary/data-plane.md Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> * Update content/ja/docs/reference/glossary/data-plane.md Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> --------- Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Fixes #46446