Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Translate data plane definition #46555

Merged
merged 6 commits into from
May 28, 2024

Conversation

tamilselvan1102
Copy link
Contributor

Fixes #46446

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kakts May 27, 2024 06:55
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2024
@tamilselvan1102
Copy link
Contributor Author

cc @Okabe-Junya

Copy link

netlify bot commented May 27, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f15f0de
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66556872693c930008c5c35d
😎 Deploy Preview https://deploy-preview-46555--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!!

I made a few comments, PTAL :)

content/ja/docs/reference/glossary/data-plane.md Outdated Show resolved Hide resolved
content/ja/docs/reference/glossary/data-plane.md Outdated Show resolved Hide resolved
@Okabe-Junya
Copy link
Member

/retitle [ja] Translate data plane definition

@k8s-ci-robot k8s-ci-robot changed the title Data plane definition in JA [ja] Translate data plane definition May 27, 2024
tamilselvan1102 and others added 2 commits May 27, 2024 14:07
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thank you!

/lgtm
/assign inductor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamilselvan1102

Sorry for the inconvenience, but I have further reviewed this translation and would like to request a few simple fixes.

(Note that this is a part of the glossary, so a very high-quality translation is required.)

/lgtm cancel

content/ja/docs/reference/glossary/data-plane.md Outdated Show resolved Hide resolved
content/ja/docs/reference/glossary/data-plane.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
tamilselvan1102 and others added 2 commits May 28, 2024 10:45
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 28f7497118737b78fad6ea712feacf5916342310

@Okabe-Junya
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 28, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 54ffdac into kubernetes:main May 28, 2024
6 checks passed
AnshumanTripathi pushed a commit to AnshumanTripathi/kubernetes-website that referenced this pull request Jun 10, 2024
* Data plane definition in JA

* Data plane definition in JA

* accepted review

Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

* Update content/ja/docs/reference/glossary/data-plane.md

Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

* Update content/ja/docs/reference/glossary/data-plane.md

Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

* Update content/ja/docs/reference/glossary/data-plane.md

Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

---------

Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Translate content/en/docs/reference/glossary/data-plane.md into Japanese
4 participants