Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about backoffLimit limitation #6227

Merged
merged 1 commit into from Nov 14, 2017

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Nov 8, 2017

As per discussed in kubernetes/kubernetes#54870, the usage of the backoffLimit has some limitations.
This PR adds a Note for this.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 2d1ac33

https://deploy-preview-6227--kubernetes-io-master-staging.netlify.com

@weiwei04
Copy link

weiwei04 commented Nov 8, 2017

shall we emphasize the difference with OnFailure and Never ? for OnFailure, the failed Pod will restart on the same kubelet host, so emptyDir/hostPath is still there, for Never the failed Pod got delete and a replacement will create on another(may be the same) kubelet host, if the Pod use emptyDir/hostPath to store some tmp data, the tmp data may be lost.

@tengqm
Copy link
Contributor Author

tengqm commented Nov 8, 2017

@weiwei04 Thanks for the suggestion. The detailed description about restart policies and the differences among them should be discussed here: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy

Feel free to help out.

@steveperry-53
Copy link
Contributor

@tengqm Are you ready for me to merge this? It looks like the discussion between you and @weiwei04 pertains to a different topic.

@tengqm
Copy link
Contributor Author

tengqm commented Nov 14, 2017

Yes. @weiwei04 was suggesting some more improvements that can be left to a future PR.

@weiwei04
Copy link

Looks good to me, sorry for the late replay @steveperry-53 I agreewith @tengqm that can be left to a future PR in another part of the docs.

@steveperry-53 steveperry-53 merged commit 9f758e6 into kubernetes:master Nov 14, 2017
@tengqm tengqm deleted the job-backoff-limit branch November 15, 2017 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants