Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update Federation API ref docs for 1.11. #9064
Deploy preview for kubernetes-io-vnext-staging processing.
Built with commit ae8b01d
mistyhacks left a comment
In https://deploy-preview-9064--kubernetes-io-vnext-staging.netlify.com/docs/reference/federation/extensions/v1beta1/definitions/ one of the tables goes all the way to the right margin and is hard to read.
In https://deploy-preview-9064--kubernetes-io-vnext-staging.netlify.com/docs/reference/federation/extensions/v1beta1/operations/ the "List or watch objects of kind DaemonSets" parameters table is awkward to read. Can we get rid of the empty Defaults column to give the Description column more room?
Side note, I am not in love with the black on dark gray header rows.
Actually the Default column seems to be almost universally empty. This makes me wonder if the script is missing something when generating them. Can you please verify?
@mistyhacks I fixed the extra white space in "v1 Model Definitions". The other points you make are reasonable, but I think those should not be goals for this point in time. Right now I think we just need to get the content updated for 1.11. Then at some point between 1.11 and 1.12, we could make the kind of improvements you are suggesting.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mistyhacks
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing