Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Reorganize docs contrib guide #9510
This is a HUGE PR to review. I'm very sorry about that. It does the following major things:
There are still some whitespace errors (trailing, mostly) that I need to find and fix. But this is ready to review.
Deploy preview for kubernetes-io-master-staging ready!
Built with commit ae0c7a0
changed the title from
WIP Reorganize docs contrib guide
Reorganize docs contrib guide
Jul 20, 2018
@mistyhacks: GitHub didn't allow me to assign the following users: tallt0m.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
referenced this pull request
Jul 23, 2018
@mistyhacks I am so happy to see this PR. Thank you for opening it!
- Great conversational style.
- Good work documenting so many of our formerly invisible processes.
- Avoid idioms, they're hard to translate.
- Replace "maintainers" with "approvers" throughout.
- Standardize references to SIG Docs unless talking about Slack channels or file paths.
@mistyhacks: GitHub didn't allow me to assign the following users: cody-clark.
@mistyhacks: GitHub didn't allow me to request PR reviews from the following users: cody-clark.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
Here's a summary of the operative criteria. Hopefully I got everything--other maintainers, please chime in!
Netlify build looks good:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chenopis
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing