New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize docs contrib guide #9510

Merged
merged 9 commits into from Aug 6, 2018

Conversation

@mistyhacks
Contributor

mistyhacks commented Jul 13, 2018

Preview at https://deploy-preview-9510--kubernetes-io-master-staging.netlify.com/docs/contribute/

This is a HUGE PR to review. I'm very sorry about that. It does the following major things:

  • Rewrite, reorganize, and consolidate all docs about contributing under a new Contribute section of the website, under /docs/contribute/
  • Improve and update docs about page templates, content organization, etc
  • Change the behavior of the "Edit this page" links (at bottom and top right) to go straight to the Github editor with no preliminary page in between
  • Change the text of the "Create an issue" button to "Report a problem". Include both the page URL and file name in the PR subject. I'd love to have left the subject blank to force the reporter to write a meaningful title, and include the path and file name in the issue body, but that overrides the Github issue template. Also remove reliance on Javascript to build the "Create an issue" link.
  • Lots of redirects added

There are still some whitespace errors (trailing, mostly) that I need to find and fix. But this is ready to review.

@k8sio-netlify-preview-bot

This comment has been minimized.

Show comment
Hide comment
@k8sio-netlify-preview-bot

k8sio-netlify-preview-bot Jul 13, 2018

Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ae0c7a0

https://deploy-preview-9510--kubernetes-io-master-staging.netlify.com

Collaborator

k8sio-netlify-preview-bot commented Jul 13, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ae0c7a0

https://deploy-preview-9510--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/XL labels Jul 18, 2018

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Jul 20, 2018

Contributor

/hold cancel

Contributor

mistyhacks commented Jul 20, 2018

/hold cancel

@mistyhacks mistyhacks changed the title from WIP Reorganize docs contrib guide to Reorganize docs contrib guide Jul 20, 2018

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Jul 20, 2018

Contributor

/assign @tallt0m
/assign @chenopis
/assign @jaredbhatti
/assign @zacharysarah
/assign @Bradamant3

Contributor

mistyhacks commented Jul 20, 2018

/assign @tallt0m
/assign @chenopis
/assign @jaredbhatti
/assign @zacharysarah
/assign @Bradamant3

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jul 20, 2018

@mistyhacks: GitHub didn't allow me to assign the following users: tallt0m.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @tallt0m
/assign @chenopis
/assign @jaredbhatti
/assign @zacharysarah
/assign @Bradamant3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot commented Jul 20, 2018

@mistyhacks: GitHub didn't allow me to assign the following users: tallt0m.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @tallt0m
/assign @chenopis
/assign @jaredbhatti
/assign @zacharysarah
/assign @Bradamant3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -1,4 +1,5 @@
<!-- Thanks for filing an issue! Before submitting, please fill in the following information. -->
<!-- See https://kubernetes.io/docs/contribute/start/ for guidance on writing an actionable issue description. -->

This comment has been minimized.

@bradtopol

bradtopol Jul 22, 2018

Contributor

Nice! Very cool to have a helpful pointer here.

@bradtopol

bradtopol Jul 22, 2018

Contributor

Nice! Very cool to have a helpful pointer here.

@@ -1,6 +1,7 @@
>^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Please delete this note before submitting the pull request.
> For 1.12 Features: set Milestone to 1.12 and Base Branch to release-1.12

This comment has been minimized.

@bradtopol

bradtopol Jul 22, 2018

Contributor

Do we have instructions somewhere that provides an example on how to set the base branch to release-1.12? For folks new to git that would be very helpful. Also do we have instructions somewhere on setting the milestone. People will ask how to do that as well

@bradtopol

bradtopol Jul 22, 2018

Contributor

Do we have instructions somewhere that provides an example on how to set the base branch to release-1.12? For folks new to git that would be very helpful. Also do we have instructions somewhere on setting the milestone. People will ask how to do that as well

@bradtopol bradtopol self-assigned this Jul 22, 2018

{{% capture overview %}}
When contributing new topics, apply one of the following templates to them.

This comment has been minimized.

@bradtopol

bradtopol Jul 23, 2018

Contributor

So awesome to have this documented!!!!

@bradtopol

bradtopol Jul 23, 2018

Contributor

So awesome to have this documented!!!!

- For `overview`, use a paragraph to set context for the entire topic.
- Add the `{{< toc >}}` shortcode to show an in-page table of contents.
- For `prerequisites`, use bullet lists when possible. Add additional
prerequisites below the ones included by default.

This comment has been minimized.

@bradtopol

bradtopol Jul 23, 2018

Contributor

Is is the < include "task-tutorial-prereqs.md> that are the default pre-requisites? This should be clarified

@bradtopol

bradtopol Jul 23, 2018

Contributor

Is is the < include "task-tutorial-prereqs.md> that are the default pre-requisites? This should be clarified

This comment has been minimized.

@mistyhacks

mistyhacks Jul 23, 2018

Contributor

I added some clarification.

@mistyhacks

mistyhacks Jul 23, 2018

Contributor

I added some clarification.

@bradtopol

This comment has been minimized.

Show comment
Hide comment
@bradtopol

bradtopol Jul 23, 2018

Contributor

@mistyhacks I made several inline comments. There is so much awesomeness in this PR. Thank you for all your hard work on this very critical PR!!!

Contributor

bradtopol commented Jul 23, 2018

@mistyhacks I made several inline comments. There is so much awesomeness in this PR. Thank you for all your hard work on this very critical PR!!!

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Jul 23, 2018

Contributor

Addressed all comments so far.

Contributor

mistyhacks commented Jul 23, 2018

Addressed all comments so far.

@zacharysarah

@mistyhacks I am so happy to see this PR. Thank you for opening it! 🌟 General feedback:

  1. Great conversational style.
  2. Good work documenting so many of our formerly invisible processes.
  3. Avoid idioms, they're hard to translate.

Specific feedback:

  1. Replace "maintainers" with "approvers" throughout.
  2. Standardize references to SIG Docs unless talking about Slack channels or file paths.
* [Staging Your Documentation Changes](http://kubernetes.io/docs/home/contribute/stage-documentation-changes/)
* [Using Page Templates](http://kubernetes.io/docs/home/contribute/page-templates/)
* [Documentation Style Guide](http://kubernetes.io/docs/home/contribute/style-guide/)
* [Start contributing](http://kubernetes.io/contribute/start/)

This comment has been minimized.

@zacharysarah

zacharysarah Jul 23, 2018

Contributor

Thanks for freshening up this section!

@zacharysarah

zacharysarah Jul 23, 2018

Contributor

Thanks for freshening up this section!

{{% capture overview %}}
If you would like to help contribute to the Kubernetes documentation or website,

This comment has been minimized.

@zacharysarah

zacharysarah Jul 23, 2018

Contributor

Nice conversational tone. 👍

@zacharysarah

zacharysarah Jul 23, 2018

Contributor

Nice conversational tone. 👍

Show outdated Hide outdated content/en/docs/contribute/_index.md
Show outdated Hide outdated content/en/docs/contribute/_index.md
Show outdated Hide outdated content/en/docs/contribute/_index.md
Show outdated Hide outdated content/en/docs/contribute/participating.md
Show outdated Hide outdated content/en/docs/contribute/participating.md
Show outdated Hide outdated content/en/docs/contribute/participating.md
Show outdated Hide outdated content/en/docs/contribute/participating.md
Show outdated Hide outdated content/en/docs/contribute/participating.md
@@ -0,0 +1,57 @@
---
content_template: templates/concept

This comment has been minimized.

@chenopis

chenopis Jul 23, 2018

Contributor

As an aside, maybe we should have a generic template because we seem to be using the concept template one for anything that is not a Task or Tutorial.

@chenopis

chenopis Jul 23, 2018

Contributor

As an aside, maybe we should have a generic template because we seem to be using the concept template one for anything that is not a Task or Tutorial.

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Jul 23, 2018

Contributor

Addressed new feedback, some questions are outstanding and may be obscured by the Github UI because those lines of the source have changed. @zacharysarah those questions are for you primarily.

Contributor

mistyhacks commented Jul 23, 2018

Addressed new feedback, some questions are outstanding and may be obscured by the Github UI because those lines of the source have changed. @zacharysarah those questions are for you primarily.

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Jul 23, 2018

Contributor

/assign @cody-clark

Contributor

mistyhacks commented Jul 23, 2018

/assign @cody-clark

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jul 23, 2018

@mistyhacks: GitHub didn't allow me to assign the following users: cody-clark.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @cody-clark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot commented Jul 23, 2018

@mistyhacks: GitHub didn't allow me to assign the following users: cody-clark.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @cody-clark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Jul 23, 2018

Contributor

Also I will wait for a little more consensus on time commitment and specific benchmarks for being added to SIG Docs, becoming a reviewer, and becoming an approver.

Contributor

mistyhacks commented Jul 23, 2018

Also I will wait for a little more consensus on time commitment and specific benchmarks for being added to SIG Docs, becoming a reviewer, and becoming an approver.

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks
Contributor

mistyhacks commented Jul 24, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jul 24, 2018

@mistyhacks: GitHub didn't allow me to request PR reviews from the following users: cody-clark.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @cody-clark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot commented Jul 24, 2018

@mistyhacks: GitHub didn't allow me to request PR reviews from the following users: cody-clark.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @cody-clark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

{{% capture overview %}}
If you would like to help contribute to the Kubernetes documentation or website,

This comment has been minimized.

@kbhawkey

kbhawkey Jul 25, 2018

Contributor

A small nit:
The left nav item for start contributing is just start. How about 'Getting Started', or a different way to say, beginner?

@kbhawkey

kbhawkey Jul 25, 2018

Contributor

A small nit:
The left nav item for start contributing is just start. How about 'Getting Started', or a different way to say, beginner?

This comment has been minimized.

@mistyhacks

mistyhacks Jul 30, 2018

Contributor

It's under a Contribute heading so I thought it would be fine to be concise. I wanted a strong call-to-action.

@mistyhacks

mistyhacks Jul 30, 2018

Contributor

It's under a Contribute heading so I thought it would be fine to be concise. I wanted a strong call-to-action.

This comment has been minimized.

@mistyhacks

mistyhacks Aug 6, 2018

Contributor

Update to say I addressed this by changing it to "Start contributing".

@mistyhacks

mistyhacks Aug 6, 2018

Contributor

Update to say I addressed this by changing it to "Start contributing".

{{% capture prerequisites %}}
{{< include "task-tutorial-prereqs.md" >}} {{< version-check >}}

This comment has been minimized.

@kbhawkey

kbhawkey Jul 25, 2018

Contributor

Why is this basic version check necessary for every task/tutorial? I could understand using a version check if the instructions in the task pertain to a specific version, otherwise, it seems odd to remind the user to check their version without saying why.

@kbhawkey

kbhawkey Jul 25, 2018

Contributor

Why is this basic version check necessary for every task/tutorial? I could understand using a version check if the instructions in the task pertain to a specific version, otherwise, it seems odd to remind the user to check their version without saying why.

This comment has been minimized.

@mistyhacks

mistyhacks Jul 30, 2018

Contributor

This was decided by the SIG when the templates were decided upon. Not my new change. :)

@mistyhacks

mistyhacks Jul 30, 2018

Contributor

This was decided by the SIG when the templates were decided upon. Not my new change. :)

@zacharysarah

This comment has been minimized.

Show comment
Hide comment
@zacharysarah

zacharysarah Jul 31, 2018

Contributor

From Slack with @mistyhacks:

still awaiting some clarification on org member / sig review / sig approver, what the specific time requirements and time-commit expectations are of each, for the docs contributor guid

Here's a summary of the operative criteria. Hopefully I got everything--other maintainers, please chime in!

Role Docs prerequisites Responsibilities
Member - PRs must be to k/website Follow the code of conduct
Reviewer - As per member
- Regularly participate in weekly SIG meetings
- As per member
- Review PRs auto-assigned by blunderbuss within 1 week
Approver - As per reviewer
- Contribute regularly for at least 3 months
- Knowledgeable with SIG Docs workflows and tooling
- As per reviewer
- Respond to PR comments/requests for review from other maintainers within 1 week
- Serve periodically as the PR Wrangler for SIG Docs
Contributor

zacharysarah commented Jul 31, 2018

From Slack with @mistyhacks:

still awaiting some clarification on org member / sig review / sig approver, what the specific time requirements and time-commit expectations are of each, for the docs contributor guid

Here's a summary of the operative criteria. Hopefully I got everything--other maintainers, please chime in!

Role Docs prerequisites Responsibilities
Member - PRs must be to k/website Follow the code of conduct
Reviewer - As per member
- Regularly participate in weekly SIG meetings
- As per member
- Review PRs auto-assigned by blunderbuss within 1 week
Approver - As per reviewer
- Contribute regularly for at least 3 months
- Knowledgeable with SIG Docs workflows and tooling
- As per reviewer
- Respond to PR comments/requests for review from other maintainers within 1 week
- Serve periodically as the PR Wrangler for SIG Docs
@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Aug 6, 2018

Contributor

I rebased, fixed the nits pointed out by @kbhawkey , and updated the participating.md with more details and to include SIG Docs chair. Thanks everyone for your reviews. I think barring anything major that is wrong here, this is ready to go in and we can iterate.

/assign @chenopis

Contributor

mistyhacks commented Aug 6, 2018

I rebased, fixed the nits pointed out by @kbhawkey , and updated the participating.md with more details and to include SIG Docs chair. Thanks everyone for your reviews. I think barring anything major that is wrong here, this is ready to go in and we can iterate.

/assign @chenopis

All of this feedback was addressed.

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Aug 6, 2018

Contributor

Troubleshooting netlify failure.

Contributor

mistyhacks commented Aug 6, 2018

Troubleshooting netlify failure.

@chenopis chenopis added the team/google label Aug 6, 2018

@chenopis

This comment has been minimized.

Show comment
Hide comment
@chenopis

chenopis Aug 6, 2018

Contributor

Netlify build looks good:

3:39:04 PM: Build ready to start
3:39:05 PM: build-image version: 7c49b266ed8abd833dee6036ec0a4b9ee887658a
3:39:05 PM: buildbot version: f58df58ab0bceffdcb8d1e60fec992495a2a6751
3:39:05 PM: Fetching cached dependencies
3:39:06 PM: Starting to download cache of 314.6MB
3:39:07 PM: Finished downloading cache in 1.403494345s
3:39:07 PM: Starting to extract cache
3:39:13 PM: Finished extracting cache in 6.232225962s
3:39:13 PM: Finished fetching cache in 7.787273586s
3:39:13 PM: Starting to prepare the repo for build
3:39:14 PM: Preparing Git Reference pull/9510/head
3:39:20 PM: Found netlify.toml. Overriding site configuration
3:39:20 PM: Different build command detected, going to use the one specified in the toml file: 'hugo --enableGitInfo -b $DEPLOY_PRIME_URL' versus 'hugo' in the site
3:39:20 PM: Starting build script
3:39:20 PM: Installing dependencies
3:39:21 PM: Started restoring cached node version
3:39:23 PM: Finished restoring cached node version
3:39:24 PM: v8.11.3 is already installed.
3:39:25 PM: Now using node v8.11.3 (npm v5.6.0)
3:39:25 PM: Attempting ruby version 2.2.9, read from environment
3:39:26 PM: Using ruby version 2.2.9
3:39:26 PM: Using PHP version 5.6
3:39:26 PM: Installing Hugo 0.46
3:39:26 PM: Started restoring cached go cache
3:39:26 PM: Finished restoring cached go cache
3:39:26 PM: unset GOOS;
3:39:27 PM: unset GOARCH;
3:39:27 PM: export GOROOT='/opt/buildhome/.gimme/versions/go1.10.linux.amd64';
3:39:27 PM: export PATH="/opt/buildhome/.gimme/versions/go1.10.linux.amd64/bin:${PATH}";
3:39:27 PM: go version >&2;
3:39:27 PM: export GIMME_ENV='/opt/buildhome/.gimme/env/go1.10.linux.amd64.env';
3:39:27 PM: go version go1.10 linux/amd64
3:39:27 PM: Installing missing commands
3:39:27 PM: Verify run directory
3:39:27 PM: Executing user command: hugo --enableGitInfo -b $DEPLOY_PRIME_URL
3:39:29 PM: Building sites …
3:39:37 PM:

3:39:37 PM: | EN | CN
3:39:37 PM: +------------------+------+-----+
3:39:37 PM: Pages | 1339 | 163
3:39:37 PM: Paginator pages | 232 | 0
3:39:37 PM: Non-page files | 405 | 267
3:39:37 PM: Static files | 803 | 803
3:39:37 PM: Processed images | 0 | 0
3:39:37 PM: Aliases | 3 | 1
3:39:37 PM: Sitemaps | 2 | 1
3:39:37 PM: Cleaned | 0 | 0
3:39:37 PM: Total in 8030 ms
3:39:37 PM: Caching artifacts
3:39:37 PM: Started saving pip cache
3:39:37 PM: Finished saving pip cache
3:39:37 PM: Started saving emacs cask dependencies
3:39:37 PM: Finished saving emacs cask dependencies
3:39:37 PM: Started saving maven dependencies
3:39:37 PM: Finished saving maven dependencies
3:39:37 PM: Started saving boot dependencies
3:39:37 PM: Finished saving boot dependencies
3:39:37 PM: Started saving go dependencies
3:39:37 PM: Finished saving go dependencies
3:39:37 PM: Build script success
3:39:37 PM: Starting to deploy site from 'public'
3:40:32 PM: Starting post processing
3:41:07 PM: Finished processing build request in 2m1.88368775s
3:43:02 PM: Post processing done
3:43:02 PM: Site is live

Contributor

chenopis commented Aug 6, 2018

Netlify build looks good:

3:39:04 PM: Build ready to start
3:39:05 PM: build-image version: 7c49b266ed8abd833dee6036ec0a4b9ee887658a
3:39:05 PM: buildbot version: f58df58ab0bceffdcb8d1e60fec992495a2a6751
3:39:05 PM: Fetching cached dependencies
3:39:06 PM: Starting to download cache of 314.6MB
3:39:07 PM: Finished downloading cache in 1.403494345s
3:39:07 PM: Starting to extract cache
3:39:13 PM: Finished extracting cache in 6.232225962s
3:39:13 PM: Finished fetching cache in 7.787273586s
3:39:13 PM: Starting to prepare the repo for build
3:39:14 PM: Preparing Git Reference pull/9510/head
3:39:20 PM: Found netlify.toml. Overriding site configuration
3:39:20 PM: Different build command detected, going to use the one specified in the toml file: 'hugo --enableGitInfo -b $DEPLOY_PRIME_URL' versus 'hugo' in the site
3:39:20 PM: Starting build script
3:39:20 PM: Installing dependencies
3:39:21 PM: Started restoring cached node version
3:39:23 PM: Finished restoring cached node version
3:39:24 PM: v8.11.3 is already installed.
3:39:25 PM: Now using node v8.11.3 (npm v5.6.0)
3:39:25 PM: Attempting ruby version 2.2.9, read from environment
3:39:26 PM: Using ruby version 2.2.9
3:39:26 PM: Using PHP version 5.6
3:39:26 PM: Installing Hugo 0.46
3:39:26 PM: Started restoring cached go cache
3:39:26 PM: Finished restoring cached go cache
3:39:26 PM: unset GOOS;
3:39:27 PM: unset GOARCH;
3:39:27 PM: export GOROOT='/opt/buildhome/.gimme/versions/go1.10.linux.amd64';
3:39:27 PM: export PATH="/opt/buildhome/.gimme/versions/go1.10.linux.amd64/bin:${PATH}";
3:39:27 PM: go version >&2;
3:39:27 PM: export GIMME_ENV='/opt/buildhome/.gimme/env/go1.10.linux.amd64.env';
3:39:27 PM: go version go1.10 linux/amd64
3:39:27 PM: Installing missing commands
3:39:27 PM: Verify run directory
3:39:27 PM: Executing user command: hugo --enableGitInfo -b $DEPLOY_PRIME_URL
3:39:29 PM: Building sites …
3:39:37 PM:

3:39:37 PM: | EN | CN
3:39:37 PM: +------------------+------+-----+
3:39:37 PM: Pages | 1339 | 163
3:39:37 PM: Paginator pages | 232 | 0
3:39:37 PM: Non-page files | 405 | 267
3:39:37 PM: Static files | 803 | 803
3:39:37 PM: Processed images | 0 | 0
3:39:37 PM: Aliases | 3 | 1
3:39:37 PM: Sitemaps | 2 | 1
3:39:37 PM: Cleaned | 0 | 0
3:39:37 PM: Total in 8030 ms
3:39:37 PM: Caching artifacts
3:39:37 PM: Started saving pip cache
3:39:37 PM: Finished saving pip cache
3:39:37 PM: Started saving emacs cask dependencies
3:39:37 PM: Finished saving emacs cask dependencies
3:39:37 PM: Started saving maven dependencies
3:39:37 PM: Finished saving maven dependencies
3:39:37 PM: Started saving boot dependencies
3:39:37 PM: Finished saving boot dependencies
3:39:37 PM: Started saving go dependencies
3:39:37 PM: Finished saving go dependencies
3:39:37 PM: Build script success
3:39:37 PM: Starting to deploy site from 'public'
3:40:32 PM: Starting post processing
3:41:07 PM: Finished processing build request in 2m1.88368775s
3:43:02 PM: Post processing done
3:43:02 PM: Site is live

Fix codeblock that shows how to use <codenew>
It was being interpreted as a Hugo shortcode.
@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Aug 6, 2018

Contributor

Confirmed the last commit fixed the bug that was breaking Netlify and also adds a related test to the smoke tests page. This is ready to go. 🍾

Contributor

mistyhacks commented Aug 6, 2018

Confirmed the last commit fixed the bug that was breaking Netlify and also adds a related test to the smoke tests page. This is ready to go. 🍾

@chenopis

This comment has been minimized.

Show comment
Hide comment
@chenopis

chenopis Aug 6, 2018

Contributor

/lgtm
/approve

Contributor

chenopis commented Aug 6, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 6, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenopis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot commented Aug 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenopis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ae0d0d into kubernetes:master Aug 6, 2018

3 checks passed

cla/linuxfoundation mistyhacks authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details

@mistyhacks mistyhacks deleted the mistyhacks:contribute-to-docs-reorg branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment