New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bing search for China users #9845

Merged
merged 14 commits into from Aug 16, 2018

Conversation

@xcudder
Contributor

xcudder commented Aug 14, 2018

Adds a bing search as a fallback for users behind the GFW

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 14, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot commented Aug 14, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8sio-netlify-preview-bot

This comment has been minimized.

Show comment
Hide comment
@k8sio-netlify-preview-bot

k8sio-netlify-preview-bot Aug 14, 2018

Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 94ffb09

https://deploy-preview-9845--kubernetes-io-master-staging.netlify.com

Collaborator

k8sio-netlify-preview-bot commented Aug 14, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 94ffb09

https://deploy-preview-9845--kubernetes-io-master-staging.netlify.com

@xcudder

This comment has been minimized.

Show comment
Hide comment
@xcudder

xcudder Aug 14, 2018

Contributor

Just commenting to update the certificate status

Contributor

xcudder commented Aug 14, 2018

Just commenting to update the certificate status

@dankohn

This comment has been minimized.

Show comment
Hide comment
@dankohn

dankohn Aug 14, 2018

Member

This is designed to close #9635

Member

dankohn commented Aug 14, 2018

This is designed to close #9635

@dankohn

This comment has been minimized.

Show comment
Hide comment
@dankohn
Member

dankohn commented Aug 14, 2018

@bradtopol

This comment has been minimized.

Show comment
Hide comment
@bradtopol

bradtopol Aug 16, 2018

Contributor

I believe this was discussed in the last sig docs meeting by @zparnold. I am assigning him to this PR as he gathered input from the SIG docs team regarding best direction for this PR. cc @zacharysarah

Contributor

bradtopol commented Aug 16, 2018

I believe this was discussed in the last sig docs meeting by @zparnold. I am assigning him to this PR as he gathered input from the SIG docs team regarding best direction for this PR. cc @zacharysarah

@zacharysarah

This comment has been minimized.

Show comment
Hide comment
@zacharysarah

zacharysarah Aug 16, 2018

Contributor

Because this is a pressing concern, let's merge this now and iterate on the dropdown we agreed was the better solution.

@hanjiayao Can you or a user on your team verify that search works, please? Thanks in advance. 😄 🙇

/cc @mistyhacks @zparnold

/lgtm
/approve

Contributor

zacharysarah commented Aug 16, 2018

Because this is a pressing concern, let's merge this now and iterate on the dropdown we agreed was the better solution.

@hanjiayao Can you or a user on your team verify that search works, please? Thanks in advance. 😄 🙇

/cc @mistyhacks @zparnold

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot requested a review from mistyhacks Aug 16, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot commented Aug 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fcc03c3 into kubernetes:master Aug 16, 2018

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation xcudder authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dankohn

This comment has been minimized.

Show comment
Hide comment
@dankohn

dankohn Aug 17, 2018

Member

Our colleague Tally in Beijing confirmed that this works correctly!

image

Member

dankohn commented Aug 17, 2018

Our colleague Tally in Beijing confirmed that this works correctly!

image

@dankohn dankohn referenced this pull request Aug 17, 2018

Closed

Replace Google search with Baidu search in China #9635

0 of 1 task complete
@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 17, 2018

Member

Hello from Xi'an (travelling this week), I can conform the Bing search works well too just like the screen shot above.

A couple of urls end up with 404, please take a look

image

  • https://survey.g.doubleclick.net/async_survey?site=6ip6epxiqjqn4qgzemchgtfziy
  • https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/docs/search.md?pixel
Member

dims commented Aug 17, 2018

Hello from Xi'an (travelling this week), I can conform the Bing search works well too just like the screen shot above.

A couple of urls end up with 404, please take a look

image

  • https://survey.g.doubleclick.net/async_survey?site=6ip6epxiqjqn4qgzemchgtfziy
  • https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/docs/search.md?pixel
@zacharysarah

This comment has been minimized.

Show comment
Hide comment
@zacharysarah

zacharysarah Aug 17, 2018

Contributor

@dims Those URLs are for Google site analytics, so it’s unsurprising that they’re 404. @chenopis, any thoughts about what or whether to take action?

Contributor

zacharysarah commented Aug 17, 2018

@dims Those URLs are for Google site analytics, so it’s unsurprising that they’re 404. @chenopis, any thoughts about what or whether to take action?

@dankohn

This comment has been minimized.

Show comment
Hide comment
@dankohn

dankohn Aug 17, 2018

Member

Our understanding is that Google Analytics works in China if you turn off a couple advanced features: https://grizzlypandamarketing.com/use-google-analytics-china/

@kbarnard10 Could you please work with Nate to do so on the kubernetes.io Google Analytics account?

Member

dankohn commented Aug 17, 2018

Our understanding is that Google Analytics works in China if you turn off a couple advanced features: https://grizzlypandamarketing.com/use-google-analytics-china/

@kbarnard10 Could you please work with Nate to do so on the kubernetes.io Google Analytics account?

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 17, 2018

Member

Ack @dankohn

@zacharysarah there wasn't really a problem with the search itself, i went looking for issues with the inspector and noticed them. i'll be heading back home in about 6 hours :)

Member

dims commented Aug 17, 2018

Ack @dankohn

@zacharysarah there wasn't really a problem with the search itself, i went looking for issues with the inspector and noticed them. i'll be heading back home in about 6 hours :)

@xiangpengzhao

This comment has been minimized.

Show comment
Hide comment
@xiangpengzhao

xiangpengzhao Aug 18, 2018

Member

@dims just know you were in Xi'an. Missed a chance to meet you :(

Member

xiangpengzhao commented Aug 18, 2018

@dims just know you were in Xi'an. Missed a chance to meet you :(

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 19, 2018

Member

Ah dang! sorry @xiangpengzhao next time i will ping you.

Member

dims commented Aug 19, 2018

Ah dang! sorry @xiangpengzhao next time i will ping you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment