Skip to content

fix: remove DNS events from dedup cache #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthyx merged 2 commits into from
Apr 17, 2026
Merged

fix: remove DNS events from dedup cache #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e1d8c7
fix: remove DNS events from dedup cache
slashben Apr 16, 2026
6f8b984
fix: retry pip install in benchmark to handle transient SSL errors
slashben Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
python-version: '3.12'

- name: Install Python dependencies
run: pip install -r benchmark/requirements.txt
run: pip install -r benchmark/requirements.txt || pip install -r benchmark/requirements.txt

- name: Run benchmark
env:
Expand Down
8 changes: 3 additions & 5 deletions pkg/containerwatcher/v2/event_handler_factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ func (ma *ManagerAdapter) ReportEvent(eventType utils.EventType, event utils.K8s
const (
dedupTTLOpen uint16 = 156 // 10s
dedupTTLNetwork uint16 = 78 // 5s
dedupTTLDNS uint16 = 156 // 10s
dedupTTLCapabilities uint16 = 156 // 10s
dedupTTLHTTP uint16 = 31 // 2s
dedupTTLSSH uint16 = 156 // 10s
Expand Down Expand Up @@ -228,10 +227,9 @@ func computeEventDedupKey(enrichedEvent *events.EnrichedEvent) (key uint64, ttl
dst := e.GetDstEndpoint()
return dedupcache.ComputeNetworkKey(mntns, pid, dst.Addr, e.GetDstPort(), e.GetProto()), dedupTTLNetwork, true
}
case utils.DnsEventType:
if e, ok := event.(utils.DNSEvent); ok {
return dedupcache.ComputeDNSKey(mntns, e.GetDNSName()), dedupTTLDNS, true
}
// DNS events are not deduplicated: the system resolver cache already
// limits DNS traffic at the network layer, so events reaching the eBPF
// tracer are almost always unique.
case utils.CapabilitiesEventType:
if e, ok := event.(utils.CapabilitiesEvent); ok {
pid := uint32(0)
Expand Down
Loading