Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional templates #4

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Conversation

dipankardas011
Copy link
Contributor

This PR is for the Addition of Persistent Volume Claim, Persistent Volume, and StatefulSet
#3

Changes/Added

  • Persistent Volume Claim/
  • Persistent Volume/
  • StatefulSet/

Checklist

  • tested locally
  • added new dependencies
  • updated the docs

Signed-off-by: Dipankar Das <dipsonu10@hotmail.com>
also added the entries to the package.json

Signed-off-by: Dipankar Das <dipsonu10@hotmail.com>
Signed-off-by: Dipankar Das <dipsonu10@hotmail.com>
@chlete
Copy link

chlete commented Apr 25, 2022

Thank @dipankardas011, we will have a look at it and review it!

Added the VolumeName property
@dipankardas011
Copy link
Contributor Author

Leaving a message, just in case forgotten🙂

@dipankardas011
Copy link
Contributor Author

Leaving a message, just in case forgottenslightly_smiling_face
#3

@erdkse
Copy link
Contributor

erdkse commented Jun 14, 2022

thank you for your message @dipankardas011 , I am looking for it now

@dipankardas011
Copy link
Contributor Author

@erdkse resolved

@erdkse
Copy link
Contributor

erdkse commented Jun 14, 2022

thank you @dipankardas011 for your hard work!

@erdkse erdkse merged commit 98c3511 into kubeshop:main Jun 14, 2022
@dipankardas011
Copy link
Contributor Author

thank you @dipankardas011 for your hard work!
Welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants