feat(terminal): added ZSH shell for Linux based OS #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
dipankardas011
requested review from
devcatalin,
erdkse,
jmelnych,
topliceanurazvan and
corpydev
as code owners
Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
topliceanurazvan
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Hello @dipankardas011 and thank you for contributing to Monokle! 🙌🏻
I've left some comments regarding your PR, if you have any questions please let us know.
in 'other' supported shells will get added when they are already present Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
|
@topliceanurazvan changed as you suggested |
|
Thanks for your review |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dipankar Das dipankardas0115@gmail.com
This PR...
Changes
Fixes
Screenshots
Checklist