feat(TKC-1465): expressions improvements - resolving structs, improved finalizer #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rangoo94
requested review from
exu,
nicufk,
vsukhin,
vLia,
povilasv and
dejanzele
as code owners
✅ Deploy Preview for testkube-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5067 +/- ##
===========================================
- Coverage 29.66% 25.68% -3.98%
===========================================
Files 309 310 +1
Lines 27640 27783 +143
===========================================
- Hits 8199 7136 -1063
- Misses 18652 20043 +1391
+ Partials 789 604 -185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
vsukhin
approved these changes
Feb 27, 2024
rangoo94
added a commit
that referenced
this pull request
Mar 14, 2024
…d finalizer (#5067) * fix(TKC-1465): recognition of 'none' static value * feat(TKC-1465): add helpers to compile and and resolve the expression immediately * feat(TKC-1465): add mechanism to allow to resolve expressions in the objects via tags * feat(TKC-1465): escape "{{" nicely * chore(TKC-1465): avoid unnecessary string computation while resolving struct * chore(TKC-1465): rename Resolve to SimplifyStruct * feat(TKC-1465): add option to provide extended accessor in the expressions machine * feat(TKC-1465): simplify expression finalizers, add expression machine utils
rangoo94
added a commit
that referenced
this pull request
Mar 14, 2024
…d finalizer (#5067) * fix(TKC-1465): recognition of 'none' static value * feat(TKC-1465): add helpers to compile and and resolve the expression immediately * feat(TKC-1465): add mechanism to allow to resolve expressions in the objects via tags * feat(TKC-1465): escape "{{" nicely * chore(TKC-1465): avoid unnecessary string computation while resolving struct * chore(TKC-1465): rename Resolve to SimplifyStruct * feat(TKC-1465): add option to provide extended accessor in the expressions machine * feat(TKC-1465): simplify expression finalizers, add expression machine utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
expr:""tagsNonebugfix, nicer escaping of{{)Checklist (choose whats happened)