Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tekton charts into ks-devops #62

Open
wujiahao15 opened this issue Jul 19, 2021 · 13 comments · Fixed by #100
Open

Add Tekton charts into ks-devops #62

wujiahao15 opened this issue Jul 19, 2021 · 13 comments · Fixed by #100
Assignees

Comments

@wujiahao15
Copy link
Contributor

wujiahao15 commented Jul 19, 2021

Integrate Tekton into ks-devops by adding chart installation in charts/ks-devops/charts/

/ospp-2021

@LinuxSuRen
Copy link
Member

/label ospp-2021

@JohnNiang
Copy link
Member

Is this a duplicated issue? See also #46 .

@LinuxSuRen
Copy link
Member

IMO, this is not a duplicated issue. This issue should be part of #46. Add a helm chart for Tekton cannot support Tekton.

@LinuxSuRen
Copy link
Member

/label ospp-2021

@wujiahao15
Copy link
Contributor Author

/assign flamywhale

@JohnNiang
Copy link
Member

IMO, this is not a duplicated issue. This issue should be part of #46. Add a helm chart for Tekton cannot support Tekton.

IMO, I suggest that we are supposed to reference issue #46 in PR description. So we can keep track of the tekton integration progress.

@LinuxSuRen
Copy link
Member

Please don't forget this program will last three months. It's reasonable to create a bunch of issues to track the process.

I didn't get your point from the following statement. I guess @flamywhale will create a bunch of PRs instead of one PR.

reference issue #46 in PR description

@wujiahao15
Copy link
Contributor Author

wujiahao15 commented Jul 21, 2021

Status quo

After conducting research about the tekton pipeline chart, I find that Tekton Pipelines now has an official helm chart repository called tekton-helm-chart under the CDF organization. In this case, we just need two steps to deploy tekton in the tekton-pipelines namespace of the kubernetes cluster:

  1. Add the tekton helm chart repository: helm repo add cdf https://cdfoundation.github.io/tekton-helm-chart/
  2. Install it: helm install tekton cdf/tekton-pipeline

If we install tekton pipelines successfully, we can use the kubectl get pods -n tekton-pipelines to see pods deployed by the chart. See the below messages.

# kubectl get pods -n tekton-pipelines
NAME                                           READY   STATUS    RESTARTS   AGE
tekton-pipelines-controller-6f9df8d49d-7dwcc   1/1     Running   8          21h
tekton-pipelines-webhook-57d67b5c6d-nfjk7      1/1     Running   4          21h
  • I have successfully installed tekton-pipelines (release version: 0.25.0) using the above helm chart, and have passed the tutorial in tekton docs. That is, in an other word, this helm chart repository works.

Programme discussions

  • Based on the circumstance that tekton already has an official helm chart repository and it works successfully, the next question for this issue is to discuss about the form of integrating the tekton-helm-chart into ks-devops.
  • The simplest way to integrate the chart repository is copying a fixed release (e.g. v0.25.0) of the chart repository to ks-devops/charts/ks-devops/charts/tekton and add tekton into dependency list in ks-devops/charts/ks-devops/Chart.yaml.
  • Is there a better choice to integrate the tekton-helm-chart repository?

@LinuxSuRen
Copy link
Member

I prefer to provide the simplest solution here. Install Tekton is a small part of Tekton integration with ks-devops. For example, add the Tekton chart into the dependency, add some instruction about it. Even we don't need to upload the zip file of the Tekton chart.

The most important part is about how to use Tekton in ks-devops. Let's put our energy into this part.

@wujiahao15
Copy link
Contributor Author

I prefer to provide the simplest solution here. Install Tekton is a small part of Tekton integration with ks-devops. For example, add the Tekton chart into the dependency, add some instruction about it. Even we don't need to upload the zip file of the Tekton chart.

The most important part is about how to use Tekton in ks-devops. Let's put our energy into this part.

Copy that.

@wujiahao15
Copy link
Contributor Author

@LinuxSuRen When integrating tekton chart as our subchart, I find that the namespace in tekton-helm-chart are hard-coded as tekton-pipelines, i.e. we could not install it into kubesphere-devops-system and kubesphere-devops-worker.

I cloned the repository of tekton-helm-chart locally, and I am trying to revise the tekton-helm-chart template. I got a question here, how can I discuss with others to get a change of the helm chart?

@LinuxSuRen
Copy link
Member

LinuxSuRen commented Jul 27, 2021

Creating an issue on the official repository should be the best way.

By the way, it's not a crucial problem. There's no limitation that Tekton mast be installed in the namespace kubesphere-devops-system.

@wujiahao15
Copy link
Contributor Author

Okay, I got it. The cretical problem is how to use tekton in ks-devops. The detail of the tekton deployment can iterate gradually. The most important thing is to come up with the whole integration solution.

wujiahao15 pushed a commit to wujiahao15/ks-devops that referenced this issue Aug 4, 2021
wujiahao15 pushed a commit to wujiahao15/ks-devops that referenced this issue Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants