Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete update button in gateway page #2608

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

weili520
Copy link
Contributor

@weili520 weili520 commented Nov 12, 2021

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##2551

Special notes for reviewers:

截屏2021-11-12 16 44 47

Does this PR introduced a user-facing change?

Cancel update button in gateway page.

Additional documentation, usage docs, etc.:

@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2021
@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2021
Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
Copy link
Contributor Author

@weili520 weili520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update code

@harrisonliu5
Copy link
Contributor

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 57a519848b1eccd0ad78de20d9c6b8620ed31f67

@harrisonliu5
Copy link
Contributor

/cherrypick release-3.2

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Contributor

/remove cherrypick release-3.2

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021
@ks-ci-bot ks-ci-bot merged commit 1371ed7 into kubesphere:master Nov 22, 2021
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #2625

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weili520 weili520 deleted the gateway_update branch December 2, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants