Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete helm release #1393

Merged
merged 1 commit into from Apr 9, 2021
Merged

delete helm release #1393

merged 1 commit into from Apr 9, 2021

Conversation

xyz-li
Copy link

@xyz-li xyz-li commented Apr 8, 2021

Signed-off-by: LiHui andrewli@yunify.com

Delete helm release when uninstall ks

Fixes: kubesphere/kubesphere#3678

Signed-off-by: LiHui <andrewli@yunify.com>
@ks-ci-bot ks-ci-bot added dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2021
@xyz-li
Copy link
Author

xyz-li commented Apr 8, 2021

/assign @pixiake

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2021
@pixiake
Copy link
Collaborator

pixiake commented Apr 9, 2021

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake, xyz-li

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2021
@ks-ci-bot ks-ci-bot merged commit 51d7835 into kubesphere:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some CRD cannot be deleted bu kubepshere-delete.sh
4 participants