[BACKPORT] Allow @ character in argument sanitizer #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename DEFAULT_IMAGE option to MUST_GATHER_IMAGE
It is a common practice to use SHA256 signature of container image names, like `registry.example.com/app/web@sha256:<sig>`. The argument sanitizer doesn't allow the `@` character, so these image names will be truncated and will fail to be pulled. This change adds the `@` character in the accepted characters. Signed-off-by: Fabien Dupont <fabiendupont@pm.me>
aufi
changed the title
|
Test failure is unrelated, merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.2 backport of #20
It is a common practice to use SHA256 signature of container
image names, like registry.example.com/app/web@sha256:.
The argument sanitizer doesn't allow the @ character, so these
image names will be truncated and will fail to be pulled.
This change adds the @ character in the accepted characters.