[BACKPORT] Add launcher pods logs #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending full must-gather with gathering logs of VM Launcher pods. Related to https://bugzilla.redhat.com/show_bug.cgi?id=1995075
Update VM parsing to use Plan instead of VMImport
Adding information about empty files filtering of targeted must-gather to README.
Removing golang image from docker registry which was used for pprof gathering which is not part of forklift-must-gather.
Forklift 2.2 replaced VMIO functions, adapting the gathering code to correctly parsing VM-related objects (VM itself, DVs). As a sideeffect, VM name (instead of within-plan ID) is used be passed in parameters (as Forklift UI already does). Fixes BZs: https://bugzilla.redhat.com/show_bug.cgi?id=2019307 https://bugzilla.redhat.com/show_bug.cgi?id=1995197 https://bugzilla.redhat.com/show_bug.cgi?id=2020014
Adding virt-launcher pod logs to be captured for all matching VMs. Note, the launcher pod logs are dedicated to their VMs, so there is no additional filtering applied to the given launcher pod logs. Related to https://bugzilla.redhat.com/show_bug.cgi?id=1995075
|
Sorry for messy commits in the PR, code changes are OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.2 backport of #16
Extending both full and targeted must-gather log gathering with logs of VM's virt-launcher pods.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1995075