Bug 2064336: Fix log collection of virtv2v pods with long names #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virtv2v pods are named based on the plan name and VM id. If the plan and VM id are too long, the name of the pod will be truncated and not contain the entire plan or VM id. Targeted log collection will fail for such a pod, as the collection script attempts to grep for the entire VM id in the pod name. Because the collection script already filters for pods based on the vmID label, this additional grep for the VM id in the pod name should be redundant. Removing it allows the pod to be found and logs collected. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2064336
mansam
changed the title
|
Bug was not moved to POST but was valid. Something went wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtv2v pods are named based on the plan name and VM id. If the plan and VM id are too long, the name of the pod will be truncated and not contain the entire plan or VM id. Targeted log collection will fail for such a pod, as the collection script attempts to grep for the entire VM id in the pod name.
Because the collection script already filters for pods based on the vmID label, this additional grep for the VM id in the pod name should be redundant. Removing it allows the pod to be found and logs collected.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2064336