Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

[BZ#1951023] Add highlighting of partially-matched search terms in text-based filters throughout the UI #430

Closed
mturley opened this issue Feb 18, 2021 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. low-priority v2.3.0

Comments

@mturley
Copy link
Collaborator

mturley commented Feb 18, 2021

https://bugzilla.redhat.com/show_bug.cgi?id=1951023

Originally suggested by @fdupont-redhat for the Target Namespace field of the plan wizard as part of https://bugzilla.redhat.com/show_bug.cgi?id=1929731. We decided we should only do this if we do it consistently everywhere.

A basic implementation was done in f80c692 that I am reverting. We could revisit that and abstract it out into lib-ui as some kind of component like TextWithSubstringHighlight. Also, that implementation is case-sensitive, ideally we could highlight results even if they don't match the case of the search term (not an issue for k8s resources though since they cannot contain capital letters).

Screen Shot 2021-02-17 at 3 52 07 PM

@mturley mturley added kind/feature Categorizes issue or PR as related to a new feature. low-priority labels Feb 18, 2021
@mturley mturley changed the title Add highlighting of search terms in text-based filters throughout the UI Add highlighting of partially-matched search terms in text-based filters throughout the UI Feb 18, 2021
@mturley mturley changed the title Add highlighting of partially-matched search terms in text-based filters throughout the UI [BZ#1951023] Add highlighting of partially-matched search terms in text-based filters throughout the UI May 11, 2021
@mturley mturley added the v2.2.0 label Jun 30, 2021
@mturley mturley self-assigned this Oct 12, 2021
@mturley mturley added v2.3.0 and removed v2.2.0 labels Oct 12, 2021
@mturley
Copy link
Collaborator Author

mturley commented Mar 31, 2022

This was closed as WONTFIX in bugzilla.

@mturley mturley closed this as completed Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. low-priority v2.3.0
Projects
None yet
Development

No branches or pull requests

1 participant