Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

[BZ#1978785] Navigating to /providers route redirects to /providers/:providerType as a history.push(), should be history.replace() so that the back button works #543

Closed
mturley opened this issue Apr 9, 2021 · 0 comments · Fixed by #684
Assignees

Comments

@mturley
Copy link
Collaborator

mturley commented Apr 9, 2021

If you click the Providers nav link, you get two entries pushed into your browser history (first the root providers page, then a redirect to the tab for a specific provider type). Clicking Back in the browser takes you back to the root providers page which then redirects you forward again, there's no way to go back two levels.

If we change that history.push to a history.replace on this line: https://github.com/konveyor/forklift-ui/blob/main/src/app/Providers/ProvidersPage.tsx#L80 the root providers page will not end up in the history, and the Back button will work as expected.

https://bugzilla.redhat.com/show_bug.cgi?id=1978785

@mturley mturley self-assigned this Jun 30, 2021
@mturley mturley changed the title Navigating to /providers route redirects to /providers/:providerType as a history.push(), should be history.replace() so that the back button works [BZ#1978785] Navigating to /providers route redirects to /providers/:providerType as a history.push(), should be history.replace() so that the back button works Jul 2, 2021
@ghost ghost closed this as completed in #684 Jul 5, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant